Skip to content

Add support for annotations on attributes and groups#645

Merged
lquerel merged 7 commits intoopen-telemetry:mainfrom
lquerel:annotations
Mar 26, 2025
Merged

Add support for annotations on attributes and groups#645
lquerel merged 7 commits intoopen-telemetry:mainfrom
lquerel:annotations

Conversation

@lquerel
Copy link
Contributor

@lquerel lquerel commented Mar 21, 2025

See open-telemetry/semantic-conventions#1462 (comment) for more context.

This PR adds an annotations field to the definition of attributes and groups. In this initial iteration, annotations are opaque to Weaver and represented as a key→YAML-value map.

Annotations become accessible, after registry resolution, within JQ expressions, Jinja templates, and the Rego engine.

In the future, we may introduce a new group type allowing users to define the structure of annotations directly within the semconv registry.

@lquerel lquerel requested a review from a team as a code owner March 21, 2025 02:36
@lquerel lquerel self-assigned this Mar 21, 2025
@lquerel lquerel added the enhancement New feature or request label Mar 21, 2025
@lquerel lquerel moved this to Next Release in OTel Weaver Project Mar 21, 2025
@codecov
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

Attention: Patch coverage is 44.15584% with 43 lines in your changes missing coverage. Please review.

Project coverage is 73.7%. Comparing base (0316b08) to head (0b307df).

Files with missing lines Patch % Lines
crates/weaver_semconv/src/lib.rs 33.3% 42 Missing ⚠️
crates/weaver_resolved_schema/src/lineage.rs 88.8% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #645     +/-   ##
=======================================
- Coverage   74.2%   73.7%   -0.5%     
=======================================
  Files         57      57             
  Lines       4578    4655     +77     
=======================================
+ Hits        3399    3433     +34     
- Misses      1179    1222     +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lquerel lquerel requested a review from a team as a code owner March 21, 2025 22:50
Copy link
Member

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Schema changes look good to me!

(Rust code too, but I'm not qualified)

Copy link
Contributor

@jerbly jerbly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lquerel lquerel enabled auto-merge (squash) March 26, 2025 14:11
@lquerel lquerel merged commit 4b38aea into open-telemetry:main Mar 26, 2025
23 checks passed
@github-project-automation github-project-automation bot moved this from Next Release to Done in OTel Weaver Project Mar 26, 2025
@lquerel lquerel deleted the annotations branch April 20, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants