Add support for annotations on attributes and groups#645
Merged
lquerel merged 7 commits intoopen-telemetry:mainfrom Mar 26, 2025
Merged
Add support for annotations on attributes and groups#645lquerel merged 7 commits intoopen-telemetry:mainfrom
lquerel merged 7 commits intoopen-telemetry:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #645 +/- ##
=======================================
- Coverage 74.2% 73.7% -0.5%
=======================================
Files 57 57
Lines 4578 4655 +77
=======================================
+ Hits 3399 3433 +34
- Misses 1179 1222 +43 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lmolkova
reviewed
Mar 21, 2025
lmolkova
approved these changes
Mar 22, 2025
Member
lmolkova
left a comment
There was a problem hiding this comment.
Schema changes look good to me!
(Rust code too, but I'm not qualified)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See open-telemetry/semantic-conventions#1462 (comment) for more context.
This PR adds an
annotationsfield to the definition of attributes and groups. In this initial iteration, annotations are opaque to Weaver and represented as a key→YAML-value map.Annotations become accessible, after registry resolution, within JQ expressions, Jinja templates, and the Rego engine.
In the future, we may introduce a new group type allowing users to define the structure of annotations directly within the semconv registry.