Skip to content

fix: gate public cache inside cache impl#480

Merged
OXeu merged 1 commit intomainfrom
fix/cache-toggle-inside-cache-impl
Mar 8, 2026
Merged

fix: gate public cache inside cache impl#480
OXeu merged 1 commit intomainfrom
fix/cache-toggle-inside-cache-impl

Conversation

@OXeu
Copy link
Copy Markdown
Collaborator

@OXeu OXeu commented Mar 8, 2026

Summary

  • move the public cache toggle into CacheImpl itself instead of relying on an outer wrapper
  • ensure only the public cache store is gated by cache.enabled, while config stores remain readable to avoid recursion
  • keep the existing cache setting semantics and add a regression test covering the non-recursive config path

Testing

  • cd server && bun run check
  • cd server && bun test ./src/utils/tests/cache.test.ts ./src/services/tests/feed.test.ts ./src/services/tests/moments.test.ts

@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@OXeu OXeu merged commit 4921279 into main Mar 8, 2026
7 checks passed
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 8, 2026

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 8, 2026

🧹 Preview deployment has been cleaned up.

The temporary preview environment for this PR has been deleted.

@OXeu OXeu deleted the fix/cache-toggle-inside-cache-impl branch March 12, 2026 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant