chore(config) Default Personality Pragmatic#10705
Merged
dylan-hurd-oai merged 3 commits intomainfrom Feb 5, 2026
Merged
Conversation
joshka-oai
approved these changes
Feb 5, 2026
Collaborator
joshka-oai
left a comment
joshka-oai
left a comment
There was a problem hiding this comment.
For non test code parts of this, there likely should be a central obvious place where we set the default - either a toml file with defaults, a const name DEFAULT_PERSONALITY, or even Personality::Default. (Not a blocker)
Collaborator
Author
|
@joshka-oai agree! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switch back to Pragmatic personality
Testing