Add thread metadata update endpoint to app server#13280
Add thread metadata update endpoint to app server#13280joeytrasatti-openai merged 19 commits intomainfrom
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
@codex please review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bda2a91a2d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
I have read the CLA Document and I hereby sign the CLA |
joeytrasatti-openai
force-pushed
the
joeytrasatti-openai/codex-app-update-metadata-endpoint
branch
from
e4ddbd8 to
f9be532
Compare
|
@codex please review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2960cc9c91
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…odex-app-update-metadata-endpoint
codex-rs/app-server/tests/suite/codex_message_processor_flow.rs
Outdated
Show resolved
Hide resolved
| builder.sandbox_policy = config_snapshot.sandbox_policy.clone(); | ||
| builder.approval_mode = config_snapshot.approval_policy; | ||
| let metadata = builder.build(model_provider.as_str()); | ||
| if let Err(err) = state_db_ctx.insert_thread_if_absent(&metadata).await |
There was a problem hiding this comment.
actually, do we need to do this whole ensure thread exists in sqlite part? or can we expect all threads to be backfilled at this point cc @jif-oai
There was a problem hiding this comment.
have not removed this yet
…odex-app-update-metadata-endpoint
joeytrasatti-openai
deleted the
joeytrasatti-openai/codex-app-update-metadata-endpoint
branch
2 participants
Summary
thread/metadata/updateAPI, including protocol/schema/TypeScript exports and app-server docsgitInfoin sqlite without resuming the thread, with validation plus support for explicitnullclearsSessionMetagit fields to fill gapsblock_until_done()correctlyTesting
cargo test -p codex-state apply_rollout_items_preserves_existing_git_branch_and_fills_missing_git_fieldscargo test -p codex-state update_thread_git_info_preserves_newer_non_git_metadatacargo test -p codex-core backfill_sessions_preserves_existing_git_branch_and_fills_missing_git_fieldscargo test -p codex-app-server thread_metadata_updatecargo testcodex-coregrep-files tests withunsupported call: grep_files:suite::grep_files::grep_files_tool_collects_matchessuite::grep_files::grep_files_tool_reports_empty_results