Closed
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
recheck |
omers-oai
force-pushed
the
codex-cli-title-pr1
branch
3 times, most recently
from
64baf24 to
d68b48d
Compare
omers-oai
commented
Mar 5, 2026
| @@ -82,6 +82,14 @@ mod tests { | |||
| ); | |||
| } | |||
|
|
|||
| #[test] | |||
Author
There was a problem hiding this comment.
This is a stupid test, but there's others like it...
Personal style wise, I would merge all the really simple ones into one test method for all of them, but I don't know the codebase well... so if someone wants that let me know.
omers-oai
force-pushed
the
codex-cli-title-pr1
branch
from
d68b48d to
1d4c6ca
Compare
omers-oai
force-pushed
the
codex-cli-title-pr1
branch
from
1d4c6ca to
08a7a81
Compare
Co-authored-by: Codex <noreply@openai.com>
omers-oai
force-pushed
the
codex-cli-title-pr1
branch
from
08a7a81 to
6c91dfb
Compare
This was referenced Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to improve the experience when running multiple codex CLIs. This stack concentrates on the usage of the terminal title.
Stack 1/3. Adds a manual
/titleoverride for the terminal title, including clearing the override with empty input. (future steps will add a working spinner and attempts to populate the title automatically)