render local file links from target paths#13857
Merged
pash-openai merged 4 commits intomainfrom Mar 11, 2026
Merged
Conversation
pash-openai
force-pushed
the
codex/render-local-file-link-targets
branch
from
a77c4c5 to
8515ef2
Compare
pash-openai
force-pushed
the
codex/render-local-file-link-targets
branch
from
78be429 to
e7d342b
Compare
pash-openai
changed the title
Collaborator
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f333d14a9b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
│ ~ Render local file links from their destination paths instead of the markdown label so transcript output shows the real target path, location suffix, and cwd-relative shortening consistently across full renders, streaming output, plans, reasoning summaries, and tooltips. Carry the session cwd through the markdown render path where deferred rendering needs stable context, but keep the path types tighter while doing it. The renderer still accepts `Option<&Path>` at the boundary where cwd lookup can genuinely fail. The TUI state above that now owns `PathBuf` values and passes `&Path` instead of threading `Option<PathBuf>` through the rest of the code, which added noise without representing a real optional state. Remove `_with_cwd` from constructors whose parameters already made the cwd requirement obvious, and plumb the session cwd into the last remaining call site that had been falling back to process cwd. The tooltip history cell already had access to `Config`, so this keeps its local file-link rendering aligned with the rest of the session without extra plumbing. Add rustdoc and focused comments around the local link parsing helpers to document what each helper returns, how normalization works, and the edge cases around `file://` URLs, hash and colon location suffixes, UNC paths, and cwd-relative shortening. Keep those helpers below the Writer methods that use them so the calling context is visible first. Use `temp_dir()` in tests where the code only needs a stable absolute cwd, which avoids baking Unix- or Windows-specific root semantics into portable fixtures. Co-authored-by: Codex <noreply@openai.com>
joshka-oai
force-pushed
the
codex/render-local-file-link-targets
branch
from
ed4a5b4 to
e867c43
Compare
joshka-oai
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.