Move TUI on top of app server (in place) by etraut-openai · Pull Request #14710 · openai/codex

etraut-openai · 2026-03-14T20:20:09Z

No description provided.

etraut-openai · 2026-03-14T21:04:40Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ed0601b15b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/onboarding/auth.rs

codex-rs/tui/src/app/app_server_adapter.rs

etraut-openai · 2026-03-14T21:23:00Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3515d9b034

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/app.rs

etraut-openai · 2026-03-14T21:53:40Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: badad98b5a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/lib.rs

codex-rs/tui/src/app/app_server_adapter.rs

etraut-openai · 2026-03-14T23:04:03Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: badad98b5a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/app/app_server_adapter.rs

codex-rs/tui/src/onboarding/onboarding_screen.rs

etraut-openai · 2026-03-14T23:37:24Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 920a13fefd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/app/app_server_adapter.rs

etraut-openai · 2026-03-15T01:24:55Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 920a13fefd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/app/app_server_adapter.rs

codex-rs/tui/src/lib.rs

etraut-openai · 2026-03-15T01:58:51Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 60bb9cd15e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/app/app_server_adapter.rs

codex-rs/tui/src/onboarding/onboarding_screen.rs

etraut-openai · 2026-03-15T04:31:18Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c4a574c823

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/app/app_server_adapter.rs

etraut-openai · 2026-03-15T05:04:44Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3125bec9b9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/app/pending_interactive_replay.rs

codex-rs/tui/src/onboarding/auth/headless_chatgpt_login.rs

etraut-openai · 2026-03-15T14:26:16Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0f174c2472

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/resume_picker.rs

etraut-openai · 2026-03-15T18:26:41Z

@codex review

…p-server

chatgpt-codex-connector

💡 Codex Review

codex/codex-rs/tui/src/onboarding/auth.rs

Lines 229 to 231 in 574c841

    
           if self.is_chatgpt_login_allowed() { 
        
               options.push(SignInOption::ChatGpt); 
        
               options.push(SignInOption::DeviceCode);

Honor device-code disable flag in selectable auth options

displayed_sign_in_options correctly hides Device Code when allow_device_code_login is false, but selectable_sign_in_options still includes SignInOption::DeviceCode. Since keyboard navigation uses selectable options, users can highlight a hidden option and press Enter, which triggers start_device_code_login(). This bypasses the remote-mode restriction and can start an unsupported login flow.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/cli/src/main.rs

etraut-openai · 2026-03-15T18:55:19Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 602d74c9bd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-03-15T19:09:47Z

codex-rs/tui/src/app/app_server_adapter.rs

+        let _: ThreadUnsubscribeResponse = send_request_with_response(
+            app_server_client,
+            ClientRequest::ThreadUnsubscribe {
+                request_id: self.next_app_server_request_id(),
+                params: ThreadUnsubscribeParams {
+                    thread_id: thread_id.to_string(),
+                },
+            },
+            "thread/unsubscribe",
+        )
+        .await?;
+        self.active_turn_ids.remove(&thread_id);


Treat non-unsubscribed thread/unsubscribe as shutdown failure

unsubscribe_thread_via_app_server discards ThreadUnsubscribeResponse.status and returns Ok(()) for notLoaded/notSubscribed. handle_exit_mode then assumes shutdown was submitted and waits for a ThreadClosed update that may never arrive, so quit can stall indefinitely when the thread is already unloaded/unsubscribed.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-03-15T19:09:47Z

codex-rs/tui/src/app.rs

        self.active_thread_id = None;
        self.active_thread_rx = None;
        self.primary_thread_id = None;
-        self.pending_primary_events.clear();
+        self.pending_primary_updates.clear();
        self.chat_widget.set_pending_thread_approvals(Vec::new());
        self.sync_active_agent_label();


Clear pending request-id maps when resetting thread state

reset_thread_event_state clears channels/active thread but leaves pending request-id maps (pending_*_request_ids) intact. If a session switch occurs with unresolved approvals/tool requests, stale IDs persist and can misroute later responses (or at minimum leak memory across resets).

Useful? React with 👍 / 👎.

etraut-openai added 12 commits March 14, 2026 10:19

Part 1

709916a

Part 2

18fcca6

Part 3

cd05014

Part 4

8e103c9

Part 5

2cb13ef

Part 6

fd9fe11

Part 7

2ccb362

Part 8

1dbe04b

Part 9

be8c53a

Part 10

fb3a9ec

Auth fix

75de924

Simplification

1451ad8

etraut-openai changed the title ~~Auth fix~~ Move TUI on top of app server (in place) Mar 14, 2026

Remove reload auth

ed0601b

codex: fix CI failure on PR #14710

cc43929

chatgpt-codex-connector bot reviewed Mar 14, 2026

View reviewed changes

codex-rs/tui/src/onboarding/auth.rs Show resolved Hide resolved

codex-rs/tui/src/app/app_server_adapter.rs Show resolved Hide resolved

codex: address PR review feedback (#14710)

3515d9b

etraut-openai marked this pull request as draft March 14, 2026 21:28

chatgpt-codex-connector bot reviewed Mar 14, 2026

View reviewed changes

codex-rs/tui/src/app.rs Outdated Show resolved Hide resolved

codex: address PR review feedback (#14710)

badad98

chatgpt-codex-connector bot reviewed Mar 14, 2026

View reviewed changes

codex-rs/tui/src/lib.rs Outdated Show resolved Hide resolved

codex-rs/tui/src/app/app_server_adapter.rs Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Mar 14, 2026

View reviewed changes

codex-rs/tui/src/app/app_server_adapter.rs Outdated Show resolved Hide resolved

codex-rs/tui/src/app/app_server_adapter.rs Outdated Show resolved Hide resolved

codex-rs/tui/src/onboarding/onboarding_screen.rs Show resolved Hide resolved

codex: address PR review feedback (#14710)

920a13f

chatgpt-codex-connector bot reviewed Mar 14, 2026

View reviewed changes

codex-rs/tui/src/app/app_server_adapter.rs Outdated Show resolved Hide resolved

codex-rs/tui/src/app/app_server_adapter.rs Outdated Show resolved Hide resolved

github-actions bot mentioned this pull request Mar 15, 2026

📊 AI CLI 工具社区动态日报 2026-03-15 gsscsd/big_model_radar#37

Open

chatgpt-codex-connector bot reviewed Mar 15, 2026

View reviewed changes

codex-rs/tui/src/app/app_server_adapter.rs Outdated Show resolved Hide resolved

codex-rs/tui/src/lib.rs Outdated Show resolved Hide resolved

codex: address PR review feedback (#14710)

60bb9cd

chatgpt-codex-connector bot reviewed Mar 15, 2026

View reviewed changes

codex-rs/tui/src/app/app_server_adapter.rs Outdated Show resolved Hide resolved

codex-rs/tui/src/onboarding/onboarding_screen.rs Show resolved Hide resolved

github-actions bot mentioned this pull request Mar 15, 2026

📊 Bản tin hàng ngày công cụ AI CLI 2026-03-15 compasify/agents-radar#45

Open

codex: address PR review feedback (#14710)

c4a574c

chatgpt-codex-connector bot reviewed Mar 15, 2026

View reviewed changes

codex-rs/tui/src/app/app_server_adapter.rs Outdated Show resolved Hide resolved

codex-rs/tui/src/app/app_server_adapter.rs Outdated Show resolved Hide resolved

etraut-openai added 2 commits March 14, 2026 22:42

codex: address PR review feedback (#14710)

bcb695d

codex: address PR review feedback (#14710)

3125bec

chatgpt-codex-connector bot reviewed Mar 15, 2026

View reviewed changes

codex-rs/tui/src/app/pending_interactive_replay.rs Outdated Show resolved Hide resolved

codex-rs/tui/src/onboarding/auth/headless_chatgpt_login.rs Show resolved Hide resolved

etraut-openai added 2 commits March 15, 2026 08:15

Added remote capability

80930bd

codex: address PR review feedback (#14710)

0f174c2

chatgpt-codex-connector bot reviewed Mar 15, 2026

View reviewed changes

codex-rs/tui/src/resume_picker.rs Outdated Show resolved Hide resolved

codex-rs/tui/src/resume_picker.rs Outdated Show resolved Hide resolved

codex: address PR review feedback (#14710)

574c841

Merge remote-tracking branch 'origin/main' into etraut/move-tui-to-ap…

8e37b70

…p-server

chatgpt-codex-connector bot reviewed Mar 15, 2026

View reviewed changes

codex-rs/cli/src/main.rs Outdated Show resolved Hide resolved

codex: address PR review feedback (#14710)

602d74c

chatgpt-codex-connector bot reviewed Mar 15, 2026

View reviewed changes

codex: address PR review feedback (#14710)

b0651b3

github-actions bot mentioned this pull request Mar 16, 2026

📊 Bản tin hàng ngày công cụ AI CLI 2026-03-16 compasify/agents-radar#50

Open

etraut-openai closed this Mar 16, 2026

	if self.is_chatgpt_login_allowed() {
	options.push(SignInOption::ChatGpt);
	options.push(SignInOption::DeviceCode);

Conversation

etraut-openai commented Mar 14, 2026

Uh oh!

etraut-openai commented Mar 14, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

etraut-openai commented Mar 14, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

etraut-openai commented Mar 14, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

etraut-openai commented Mar 14, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

etraut-openai commented Mar 14, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

etraut-openai commented Mar 15, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

etraut-openai commented Mar 15, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

etraut-openai commented Mar 15, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

etraut-openai commented Mar 15, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

etraut-openai commented Mar 15, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review