tui: queue slash commands in order#14836
tui: queue slash commands in order#14836charley-oai wants to merge 3 commits intocc/tui-slash-serialization-abstractionfrom
Conversation
|
@codex review this |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a332a21a98
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
codex-rs/tui/src/chatwidget.rs
Outdated
| if self.bottom_pane.is_task_running() | ||
| && !matches!(cmd.execution_kind(), SlashCommandExecutionKind::Immediate) | ||
| { | ||
| self.queue_user_message(draft); |
There was a problem hiding this comment.
handle_serialized_slash_command only queues non-immediate drafts when is_task_running is true. If a turn finishes while an interactive popup is open, earlier queued messages remain blocked by the popup; selecting /model//permissions then executes immediately and can run before those older queued inputs. That reorders user actions and can apply context changes to the wrong turn.
Useful? React with 👍 / 👎.
charley-oai
force-pushed
the
cc/tui-slash-serialization-abstraction
branch
from
044d2b6 to
4bba26d
Compare
charley-oai
force-pushed
the
cc/tui-queueable-slash-commands
branch
from
d3c66d4 to
2335239
Compare
Introduce a small slash command invocation serializer and consolidate built-in command metadata behind a single spec table without changing slash command runtime behavior. Co-authored-by: Codex <noreply@openai.com>
Queue slash drafts while a turn is running, replay them through the same serialized slash-command path, and keep interactive command flows like /model, /review, /permissions, and /help consistent with that ordering model. Preserve queued slash command order when replay drains follow-up input. Co-authored-by: Codex <noreply@openai.com>
charley-oai
force-pushed
the
cc/tui-queueable-slash-commands
branch
from
2335239 to
5bdcd2a
Compare
Co-authored-by: Codex <noreply@openai.com>
charley-oai
force-pushed
the
cc/tui-slash-serialization-abstraction
branch
2 times, most recently
from
d2bfdd5 to
9e1f60c
Compare
1 participant
Summary
Testing