[plugins] Support plugin installation elicitation.#14896
Merged
mzeng-openai merged 6 commits intomainfrom Mar 17, 2026
Merged
Conversation
sayan-oai
reviewed
Mar 17, 2026
sayan-oai
reviewed
Mar 17, 2026
sayan-oai
reviewed
Mar 17, 2026
Collaborator
Author
|
Disabled TUI for this since plugin installation is not supported yet. |
sayan-oai
approved these changes
Mar 17, 2026
Comment on lines
+378
to
+380
| fn tool_suggest_connector_ids(config: &Config) -> HashSet<String> { | ||
| PluginsManager::new(config.codex_home.clone()) | ||
| .plugins_for_config(config) |
Collaborator
There was a problem hiding this comment.
confirming-- we only want to suggest connectors that are associated with plugins? if they have no plugins installed, this would be empty, right?
Comment on lines
101
to
+102
| return Err(FunctionCallError::RespondToModel( | ||
| "plugin tool suggestions are not currently available".to_string(), | ||
| "tool suggestions currently support only action_type=\"install\"".to_string(), |
Collaborator
There was a problem hiding this comment.
should we not tell the model that enable is an option here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It now supports: