Merged
Conversation
Start the initial yield timer only after the worker reports that code execution has started, so worker startup jitter on loaded CI runners does not consume the yield budget before user code runs. Co-authored-by: Codex <noreply@openai.com>
pakrym-oai
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is flaky
code_mode_yield_timeout_works_for_busy_loopincodex-rs/core/tests/suite/code_mode.rsintermittently failed on loaded CI runners.Why it was flaky
The initial
yield_time_msbudget started when the worker was created, not when user code actually started running.That made the test sensitive to runner startup jitter rather than to the actual code-mode yield behavior.
How this PR fixes it
startedmessage once the runtime is initialized and execution is about to begin.startedmessage arrives.Why this fix fixes the flakiness
yield_time_msnow measures execution time instead of worker boot time. Startup jitter can no longer steal the timeout budget, so the test outcome depends on the code-mode runner semantics rather than on CI machine load at worker creation.