Gate realtime audio interruption logic to v2#14984
Merged
aibrahim-oai merged 7 commits intomainfrom Mar 17, 2026
Merged
Conversation
Collaborator
aibrahim-oai
commented
Mar 17, 2026
aibrahim-oai
commented
- thread the realtime version into conversation start and app-server notifications
- keep playback-aware mic gating and playback interruption behavior on v2 only, leaving v1 on the legacy path
dylan-hurd-oai
approved these changes
Mar 17, 2026
Collaborator
dylan-hurd-oai
left a comment
dylan-hurd-oai
left a comment
There was a problem hiding this comment.
1 simplification suggestion
codex-rs/tui/src/voice.rs
Outdated
Comment on lines
+747
to
+758
| if matches!(input_behavior, RealtimeInputBehavior::Ungated) { | ||
| *allow_input_until = None; | ||
| return true; | ||
| } | ||
|
|
||
| let now = Instant::now(); | ||
| let RealtimeInputBehavior::PlaybackAware { | ||
| playback_queued_samples, | ||
| } = input_behavior | ||
| else { | ||
| unreachable!("ungated realtime input should return early"); | ||
| }; |
Collaborator
There was a problem hiding this comment.
Suggested change
| if matches!(input_behavior, RealtimeInputBehavior::Ungated) { | |
| *allow_input_until = None; | |
| return true; | |
| } | |
| let now = Instant::now(); | |
| let RealtimeInputBehavior::PlaybackAware { | |
| playback_queued_samples, | |
| } = input_behavior | |
| else { | |
| unreachable!("ungated realtime input should return early"); | |
| }; | |
| let playback_queued_samples = match input_behavior { | |
| RealtimeInputBehavior::Ungated => { | |
| *allow_input_until = None; | |
| return true; | |
| } | |
| RealtimeInputBehavior::PlaybackAware { | |
| playback_queued_samples, | |
| } => playback_queued_samples, | |
| }; | |
…audio-gate # Conflicts: # codex-rs/core/src/auth_env_telemetry.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.