feat: Add product-aware plugin policies and clean up manifest naming#14993
feat: Add product-aware plugin policies and clean up manifest naming#14993
Conversation
xl-openai
commented
Mar 17, 2026
- Add shared Product support to marketplace plugin policy and skill policy (no enforced yet).
- Move marketplace installation/authentication under policy and model it as MarketplacePluginPolicy.
- Rename plugin/marketplace local manifest types to separate raw serde shapes from resolved in-memory models.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 30f0bf99b6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| #[serde(default)] | ||
| auth_policy: MarketplacePluginAuthPolicy, | ||
| policy: RawMarketplaceManifestPluginPolicy, | ||
| #[serde(default)] |
There was a problem hiding this comment.
Parse legacy top-level marketplace policy keys
RawMarketplaceManifestPlugin now only reads the nested policy object and applies defaults when it is missing. Legacy installPolicy/authPolicy fields are silently ignored, so existing marketplace entries can flip from NOT_AVAILABLE/ON_USE to default AVAILABLE/ON_INSTALL. This changes install and auth behavior for existing marketplace.json files.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Yeah that's expected we will update existing plugins afterward.