Skip to content

feat: Add product-aware plugin policies and clean up manifest naming#14993

Merged
xl-openai merged 1 commit intomainfrom
xl/plugins2
Mar 18, 2026
Merged

feat: Add product-aware plugin policies and clean up manifest naming#14993
xl-openai merged 1 commit intomainfrom
xl/plugins2

Conversation

@xl-openai
Copy link
Copy Markdown
Collaborator

  • Add shared Product support to marketplace plugin policy and skill policy (no enforced yet).
  • Move marketplace installation/authentication under policy and model it as MarketplacePluginPolicy.
  • Rename plugin/marketplace local manifest types to separate raw serde shapes from resolved in-memory models.

@xl-openai xl-openai requested a review from sayan-oai March 17, 2026 23:19
Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 30f0bf99b6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 405 to 407
#[serde(default)]
auth_policy: MarketplacePluginAuthPolicy,
policy: RawMarketplaceManifestPluginPolicy,
#[serde(default)]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Parse legacy top-level marketplace policy keys

RawMarketplaceManifestPlugin now only reads the nested policy object and applies defaults when it is missing. Legacy installPolicy/authPolicy fields are silently ignored, so existing marketplace entries can flip from NOT_AVAILABLE/ON_USE to default AVAILABLE/ON_INSTALL. This changes install and auth behavior for existing marketplace.json files.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's expected we will update existing plugins afterward.

@xl-openai xl-openai merged commit a5d3114 into main Mar 18, 2026
33 checks passed
@xl-openai xl-openai deleted the xl/plugins2 branch March 18, 2026 00:01
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants