Skip to content

Publish runnable DotSlash package for argument-comment lint#15113

Closed
bolinfest wants to merge 1 commit intomainfrom
pr15113
Closed

Publish runnable DotSlash package for argument-comment lint#15113
bolinfest wants to merge 1 commit intomainfrom
pr15113

Conversation

@bolinfest
Copy link
Copy Markdown
Collaborator

@bolinfest bolinfest commented Mar 18, 2026

Why

The original bare-library release assets were not enough to make the repo lint flow use a prebuilt linter. tools/argument-comment-lint/run.sh still built the local lint crate via cargo dylint --path ..., so there was no runnable DotSlash payload for the repo to consume.

What Changed

  • changed the stable release packaging to publish a real argument-comment-lint DotSlash payload that contains:
    • a small runner executable
    • a bundled cargo-dylint
    • the prebuilt lint library
  • updated tools/argument-comment-lint/run.sh to prefer the latest stable DotSlash payload when dotslash is available, and to fall back to the existing local cargo dylint --path ... flow when the stable asset is not available yet or CODEX_ARGUMENT_COMMENT_LINT_USE_LOCAL=1 is set
  • added the runner binary implementation in tools/argument-comment-lint/src/bin/argument-comment-lint.rs
  • updated the release workflow and DotSlash config to publish archives whose entrypoint is the packaged runner rather than the raw library
  • documented the new behavior and the refresh knob in tools/argument-comment-lint/README.md

Verification

  • ran cd tools/argument-comment-lint && cargo test
  • ran cargo fmt --manifest-path tools/argument-comment-lint/Cargo.toml
  • validated .github/workflows/rust-release.yml and .github/workflows/rust-release-argument-comment-lint.yml with Ruby's YAML parser
  • validated .github/dotslash-argument-comment-lint-config.json with jq and a regex sanity check script
  • staged a local package containing the runner, bundled cargo-dylint, and prebuilt library, then ran the packaged argument-comment-lint executable against codex-utils-string
  • ran ./tools/argument-comment-lint/run.sh -p codex-utils-string to confirm the no-release-yet case falls back to the local build path

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5e87e4ba5e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +30 to +35
- runner: ubuntu-24.04
target: x86_64-unknown-linux-gnu
lib_name: libargument_comment_lint@nightly-2025-09-18-x86_64-unknown-linux-gnu.so
- runner: ubuntu-24.04-arm
target: aarch64-unknown-linux-gnu
lib_name: libargument_comment_lint@nightly-2025-09-18-aarch64-unknown-linux-gnu.so
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Build the published Linux lint assets on an older glibc baseline

If someone fetches the new argument-comment-lint DotSlash asset on a Linux machine older than the runner image (for example Ubuntu 22.04/20.04), these *-unknown-linux-gnu libraries will typically fail to load because they were built on ubuntu-24.04{,-arm} and inherit that runner's glibc requirement. Since .github/dotslash-argument-comment-lint-config.json publishes these exact .so files as the cross-machine release artifact, the advertised Linux x64/arm64 download will only work on the newest distros unless we build from an older GNU baseline or otherwise normalize compatibility.

Useful? React with 👍 / 👎.

@bolinfest bolinfest changed the title Publish stable DotSlash assets for argument-comment lint Publish runnable DotSlash package for argument-comment lint Mar 19, 2026
@bolinfest
Copy link
Copy Markdown
Collaborator Author

Superseded by the stacked replacement in #15198 and #15199.

@bolinfest bolinfest closed this Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant