Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5e87e4ba5e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - runner: ubuntu-24.04 | ||
| target: x86_64-unknown-linux-gnu | ||
| lib_name: libargument_comment_lint@nightly-2025-09-18-x86_64-unknown-linux-gnu.so | ||
| - runner: ubuntu-24.04-arm | ||
| target: aarch64-unknown-linux-gnu | ||
| lib_name: libargument_comment_lint@nightly-2025-09-18-aarch64-unknown-linux-gnu.so |
There was a problem hiding this comment.
Build the published Linux lint assets on an older glibc baseline
If someone fetches the new argument-comment-lint DotSlash asset on a Linux machine older than the runner image (for example Ubuntu 22.04/20.04), these *-unknown-linux-gnu libraries will typically fail to load because they were built on ubuntu-24.04{,-arm} and inherit that runner's glibc requirement. Since .github/dotslash-argument-comment-lint-config.json publishes these exact .so files as the cross-machine release artifact, the advertised Linux x64/arm64 download will only work on the newest distros unless we build from an older GNU baseline or otherwise normalize compatibility.
Useful? React with 👍 / 👎.
Why
The original bare-library release assets were not enough to make the repo lint flow use a prebuilt linter.
tools/argument-comment-lint/run.shstill built the local lint crate viacargo dylint --path ..., so there was no runnable DotSlash payload for the repo to consume.What Changed
argument-comment-lintDotSlash payload that contains:cargo-dylinttools/argument-comment-lint/run.shto prefer the latest stable DotSlash payload whendotslashis available, and to fall back to the existing localcargo dylint --path ...flow when the stable asset is not available yet orCODEX_ARGUMENT_COMMENT_LINT_USE_LOCAL=1is settools/argument-comment-lint/src/bin/argument-comment-lint.rstools/argument-comment-lint/README.mdVerification
cd tools/argument-comment-lint && cargo testcargo fmt --manifest-path tools/argument-comment-lint/Cargo.toml.github/workflows/rust-release.ymland.github/workflows/rust-release-argument-comment-lint.ymlwith Ruby's YAML parser.github/dotslash-argument-comment-lint-config.jsonwithjqand a regex sanity check scriptcargo-dylint, and prebuilt library, then ran the packagedargument-comment-lintexecutable againstcodex-utils-string./tools/argument-comment-lint/run.sh -p codex-utils-stringto confirm the no-release-yet case falls back to the local build path