-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[hooks] add non-streaming (non-stdin style) shell-only PostToolUse support #15531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
bf04633
PostToolUse for Bash-style tools only
eternal-openai b731065
Align PostToolUse feedback semantics
eternal-openai a9375f0
Ignore current aws-lc cargo-deny advisories
eternal-openai 285b9f8
codex: use raw bash output for post-tool-use hooks (#15531)
eternal-openai ecb586c
Stabilize shell snapshot apply_patch test
eternal-openai 5a4c417
Relax macOS resume interrupt assertion
eternal-openai 8958492
Align PostToolUse block feedback semantics
eternal-openai d10f912
codex: fix argument comment lint on PR #15531
eternal-openai 9baf815
pretooluse pr fixes, general hardening
eternal-openai 1d5cdee
Merge remote-tracking branch 'origin/main' into hooks-posttooluse-bas…
eternal-openai a10ebab
Simplify bash post-tool-use scope
eternal-openai 0ea0d64
Restore post-tool-use for one-shot exec commands
eternal-openai c0274bc
review cleanups
eternal-openai bc85657
codex: fix CI failure on PR #15531
eternal-openai 2e3dca3
codex: inline post tool use payload helpers
eternal-openai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,6 +4,7 @@ | |
| "HookEventName": { | ||
| "enum": [ | ||
| "preToolUse", | ||
| "postToolUse", | ||
| "sessionStart", | ||
| "userPromptSubmit", | ||
| "stop" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,6 +4,7 @@ | |
| "HookEventName": { | ||
| "enum": [ | ||
| "preToolUse", | ||
| "postToolUse", | ||
| "sessionStart", | ||
| "userPromptSubmit", | ||
| "stop" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what should this property contain for a notmal tool output?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By default it should be None. A tool only populates post_tool_use_response if it intentionally supports a stable PostToolUse payload shape