Conversation
This was referenced Apr 3, 2026
rhan-oai
force-pushed
the
pr16640
branch
2 times, most recently
from
426b81a to
0e16d53
Compare
This was referenced Apr 3, 2026
rhan-oai
force-pushed
the
pr16640
branch
14 times, most recently
from
28eb69b to
44463cb
Compare
rhan-oai
force-pushed
the
pr16640
branch
2 times, most recently
from
6e02a3f to
d3f41f1
Compare
rhan-oai
force-pushed
the
pr16640
branch
3 times, most recently
from
0bb2e8d to
df708ee
Compare
owenlin0
reviewed
Apr 7, 2026
| turn_id, | ||
| token_usage, | ||
| }; | ||
| if let Some(analytics_events_client) = analytics_events_client { |
Collaborator
There was a problem hiding this comment.
do we still need these changes now that we're emitting a custom turn token fact?
owenlin0
approved these changes
Apr 7, 2026
rhan-oai
force-pushed
the
pr16640
branch
2 times, most recently
from
2397bff to
df708ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack created with Sapling. Best reviewed with ReviewStack.