feat: add opt-in provider runtime abstraction#17713
Conversation
7796ab2 to
4d9d09d
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
codex/codex-rs/core/src/codex.rs
Lines 1744 to 1746 in 4d9d09d
Session::new still builds auth-env telemetry from the legacy provider and base auth manager. When ProviderRuntime::Resolved is active, request auth can come from resolved auth state (env/static/command) and a different auth manager, so startup telemetry reports incorrect auth-env context and can mislead diagnostics.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
32c5bd3 to
834c4a9
Compare
this seems to be a small tech debt. Cleaning it up as part of this PR. |
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
84c82b0 to
b5c6093
Compare
b5c6093 to
30c7e0a
Compare
|
@codex review |
a13e12b to
4393774
Compare
c6f1a7d to
995e851
Compare
995e851 to
d4f7674
Compare
ee65513 to
7d0908f
Compare
8d91aed to
fb75598
Compare
cacdc42 to
edef482
Compare
edef482 to
3f31f3c
Compare
Summary
codex-model-provideras the runtime home for model-provider behavior that does not belong incodex-core,codex-login, orcodex-api.ModelProviderInfoin aModelProvidertrait object that can resolve the API provider config, provider-scoped auth manager, and request auth provider for each call.Tests
Ran tests manually to make sure that provider auth under different configs still work as expected.