[7/8] Cover MCP stdio tests with executor placement#18025
Merged
aibrahim-oai merged 1 commit intodev/remote-mcp-executor-stdiofrom Apr 16, 2026
Merged
[7/8] Cover MCP stdio tests with executor placement#18025aibrahim-oai merged 1 commit intodev/remote-mcp-executor-stdiofrom
aibrahim-oai merged 1 commit intodev/remote-mcp-executor-stdiofrom
Conversation
aibrahim-oai
changed the title
aibrahim-oai
force-pushed
the
dev/remote-mcp-stdio
branch
from
d997af8 to
8bd31fe
Compare
aibrahim-oai
force-pushed
the
dev/remote-mcp-stdio-tests
branch
from
c238b74 to
04edeeb
Compare
aibrahim-oai
force-pushed
the
dev/remote-mcp-stdio
branch
from
8bd31fe to
e2510f7
Compare
aibrahim-oai
force-pushed
the
dev/remote-mcp-stdio-tests
branch
from
04edeeb to
db17256
Compare
aibrahim-oai
force-pushed
the
dev/remote-mcp-stdio
branch
from
e2510f7 to
912b400
Compare
aibrahim-oai
force-pushed
the
dev/remote-mcp-stdio-tests
branch
2 times, most recently
from
aa58931 to
c4a27cd
Compare
aibrahim-oai
force-pushed
the
dev/remote-mcp-stdio
branch
from
912b400 to
7e94d1f
Compare
aibrahim-oai
added a commit
that referenced
this pull request
Apr 16, 2026
## Summary - Add an MCP server environment setting with local as the default. - Thread the default through config serialization, schema generation, and existing config fixtures. ## Stack ```text o #18027 [8/8] Fail exec client operations after disconnect │ o #18025 [7/8] Cover MCP stdio tests with executor placement │ o #18089 [6/8] Wire remote MCP stdio through executor │ o #18088 [5/8] Add executor process transport for MCP stdio │ o #18087 [4/8] Abstract MCP stdio server launching │ o #18020 [3/8] Add pushed exec process events │ o #18086 [2/8] Support piped stdin in exec process API │ @ #18085 [1/8] Add MCP server environment config │ o main ``` Co-authored-by: Codex <noreply@openai.com>
aibrahim-oai
force-pushed
the
dev/remote-mcp-stdio
branch
from
7e94d1f to
2f30ec1
Compare
aibrahim-oai
force-pushed
the
dev/remote-mcp-stdio-tests
branch
2 times, most recently
from
1e3bb61 to
fa90957
Compare
aibrahim-oai
force-pushed
the
dev/remote-mcp-stdio
branch
from
2f30ec1 to
74ca01c
Compare
aibrahim-oai
force-pushed
the
dev/remote-mcp-stdio-tests
branch
from
fa90957 to
e420153
Compare
aibrahim-oai
force-pushed
the
dev/remote-mcp-stdio
branch
2 times, most recently
from
87f5c4c to
a375ead
Compare
aibrahim-oai
force-pushed
the
dev/remote-mcp-stdio-tests
branch
from
e420153 to
1722c69
Compare
aibrahim-oai
force-pushed
the
dev/remote-mcp-stdio
branch
from
a375ead to
19c53cb
Compare
aibrahim-oai
force-pushed
the
dev/remote-mcp-stdio-tests
branch
2 times, most recently
from
580771d to
f694598
Compare
aibrahim-oai
force-pushed
the
dev/remote-mcp-stdio
branch
2 times, most recently
from
2f93c75 to
6ca1f6b
Compare
aibrahim-oai
force-pushed
the
dev/remote-mcp-stdio-tests
branch
2 times, most recently
from
c2713b6 to
acd96bd
Compare
aibrahim-oai
force-pushed
the
dev/remote-mcp-stdio
branch
from
6ca1f6b to
825a0cb
Compare
aibrahim-oai
added a commit
that referenced
this pull request
Apr 16, 2026
## Summary - Add an explicit stdin mode to process/start. - Keep normal non-interactive exec stdin closed while allowing pipe-backed processes. ## Stack ```text o #18027 [8/8] Fail exec client operations after disconnect │ o #18025 [7/8] Cover MCP stdio tests with executor placement │ o #18089 [6/8] Wire remote MCP stdio through executor │ o #18088 [5/8] Add executor process transport for MCP stdio │ o #18087 [4/8] Abstract MCP stdio server launching │ o #18020 [3/8] Add pushed exec process events │ @ #18086 [2/8] Support piped stdin in exec process API │ o #18085 [1/8] Add MCP server environment config │ o main ``` Co-authored-by: Codex <noreply@openai.com>
aibrahim-oai
force-pushed
the
dev/remote-mcp-stdio
branch
from
825a0cb to
a58a26f
Compare
aibrahim-oai
force-pushed
the
dev/remote-mcp-stdio-tests
branch
from
acd96bd to
88e5a56
Compare
aibrahim-oai
force-pushed
the
dev/remote-mcp-stdio
branch
from
a58a26f to
cfba2ef
Compare
aibrahim-oai
force-pushed
the
dev/remote-mcp-stdio-tests
branch
2 times, most recently
from
adbbe17 to
c970502
Compare
aibrahim-oai
force-pushed
the
dev/remote-mcp-stdio
branch
from
cfba2ef to
109a540
Compare
aibrahim-oai
force-pushed
the
dev/remote-mcp-stdio-tests
branch
from
c970502 to
884fe95
Compare
aibrahim-oai
force-pushed
the
dev/remote-mcp-stdio
branch
from
109a540 to
81a3281
Compare
aibrahim-oai
force-pushed
the
dev/remote-mcp-stdio-tests
branch
from
884fe95 to
60f3ca5
Compare
Co-authored-by: Codex <noreply@openai.com>
aibrahim-oai
force-pushed
the
dev/remote-mcp-stdio
branch
from
81a3281 to
fdfe2ca
Compare
aibrahim-oai
force-pushed
the
dev/remote-mcp-stdio-tests
branch
from
60f3ca5 to
a087158
Compare
pakrym-oai
reviewed
Apr 16, 2026
| #[tokio::test(flavor = "multi_thread", worker_threads = 1)] | ||
| #[serial(mcp_test_value)] | ||
| async fn stdio_server_round_trip() -> anyhow::Result<()> { | ||
| async fn stdio_server_round_trip(stdio_environment: StdioMcpTestEnvironment) -> anyhow::Result<()> { |
Collaborator
There was a problem hiding this comment.
can you use the build_remote_aware infra here?
Base automatically changed from
dev/remote-mcp-stdio
to
dev/remote-mcp-executor-stdio
April 16, 2026 21:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
cargo check -p codex-core --test allcargo testper repo instruction; CI will cover.Stack