Skip to content

Use in-process app-server for unknown-thread MCP read test#18196

Merged
mzeng-openai merged 3 commits intomainfrom
dev/mzeng/fix-unknown-thread-read-error
Apr 16, 2026
Merged

Use in-process app-server for unknown-thread MCP read test#18196
mzeng-openai merged 3 commits intomainfrom
dev/mzeng/fix-unknown-thread-read-error

Conversation

@mzeng-openai
Copy link
Copy Markdown
Collaborator

Summary

  • Switch the unknown-thread MCP resource read test from the stdio subprocess to the in-process app-server path.
  • Keep the assertion focused on the returned error message while avoiding child-process teardown timing issues in nextest.

Testing

  • Not run (not requested)

@mzeng-openai mzeng-openai marked this pull request as ready for review April 16, 2026 20:15
Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c494f3c003

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/app-server/tests/suite/v2/mcp_resource.rs Outdated
Comment thread codex-rs/app-server/tests/suite/v2/mcp_resource.rs Outdated
Copy link
Copy Markdown
Collaborator

@bolinfest bolinfest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tightening up this test!

Comment thread codex-rs/app-server/tests/suite/v2/mcp_resource.rs Outdated
@mzeng-openai mzeng-openai enabled auto-merge (squash) April 16, 2026 23:45
@mzeng-openai mzeng-openai merged commit bf6e7e1 into main Apr 16, 2026
25 checks passed
@mzeng-openai mzeng-openai deleted the dev/mzeng/fix-unknown-thread-read-error branch April 16, 2026 23:46
@github-actions github-actions bot locked and limited conversation to collaborators Apr 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants