Skip to content

[codex] Tighten external migration prompt tests#18768

Merged
alexsong-oai merged 4 commits intomainfrom
alexs/tigten-external-migration-test
Apr 21, 2026
Merged

[codex] Tighten external migration prompt tests#18768
alexsong-oai merged 4 commits intomainfrom
alexs/tigten-external-migration-test

Conversation

@alexsong-oai
Copy link
Copy Markdown
Collaborator

@alexsong-oai alexsong-oai commented Apr 20, 2026

Summary

  • use platform-specific project path fixtures in external_agent_config_migration prompt tests
  • keep the existing POSIX snapshot for non-Windows test runs
  • add a Windows-specific snapshot for the prompt rendering on Windows

Why

The previous test fixture used POSIX-style absolute project paths and implicitly relied on display_path_for() normalizing them to project-relative paths. That assumption held for the non-Windows snapshot, but it did not hold for the failing Windows Cargo run, which rendered absolute project paths instead.

This change keeps the test coverage focused on the actual behavior of each platform by feeding Windows-style project paths on Windows and POSIX-style project paths elsewhere.

Validation

  • just fmt
  • attempted cargo test -p codex-tui external_agent_config_migration::tests:: locally, but the build did not complete before I pushed this update

Notes

Per the repo instructions, I did not rerun tests after the final just fmt pass.

@alexsong-oai alexsong-oai marked this pull request as ready for review April 20, 2026 23:47
@alexsong-oai alexsong-oai enabled auto-merge (squash) April 20, 2026 23:57
@alexsong-oai alexsong-oai requested a review from xl-openai April 21, 2026 19:31
@alexsong-oai alexsong-oai merged commit 6bbd710 into main Apr 21, 2026
25 checks passed
@alexsong-oai alexsong-oai deleted the alexs/tigten-external-migration-test branch April 21, 2026 23:20
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants