Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
build_prompt_inputnow initializesExecServerRuntimePaths, which requires a configured Codex executable path. The previous inline unit test incore/src/prompt_debug.rsbuilt a baretest_config()and then failed before it could assert anything useful:This coverage is also integration-shaped: it drives the public
build_prompt_inputentry point through config, thread, and session setup rather than testing a small internal helper in isolation.Bazel CI did not catch this earlier because the affected test was behind the same wrapped Rust unit-test path fixed by #18913. Before that launcher/sharding fix, the outer
workspace_root_testchanged the working directory for Insta compatibility while the innerrules_rustsharding wrapper still expected its runfiles working directory. In practice, Bazel could report success without executing the Rust test cases in that shard. Once #18913 makes the wrapper run the Rust test binary directly and shard with libtest arguments, this stale unit test actually runs and exposes the missingcodex_self_exesetup.What Changed
build_prompt_input_includes_context_and_user_messageout ofcore/src/prompt_debug.rs.core/tests/suite/prompt_debug_tests.rsand registered it fromcore/tests/suite/mod.rs.ConfigBuilderand providescodex_self_exeusing the current test executable, matching the runtime-path invariant required by prompt debug setup.Verification
cargo test -p codex-core --test all prompt_debug_tests::build_prompt_input_includes_context_and_user_messagebazel test //codex-rs/core:core-all-test --test_arg=prompt_debug_tests::build_prompt_input_includes_context_and_user_message --test_output=errorsStack created with Sapling. Best reviewed with ReviewStack.