Skip to content

Add an = to <= check in embedding_utils#118

Merged
hallacy merged 1 commit intomainfrom
hallacy/fix_embedding_utils
Aug 26, 2022
Merged

Add an = to <= check in embedding_utils#118
hallacy merged 1 commit intomainfrom
hallacy/fix_embedding_utils

Conversation

@hallacy
Copy link
Copy Markdown
Collaborator

@hallacy hallacy commented Aug 26, 2022

No description provided.

Copy link
Copy Markdown
Collaborator

@ted-at-openai ted-at-openai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested that 2048 is the correct limit, and it is. Error message from exceeding 2048 is vague: ... is not valid under any of the given schemas - 'input'. Change looks good to me.

@hallacy hallacy merged commit e51ae91 into main Aug 26, 2022
@hallacy hallacy deleted the hallacy/fix_embedding_utils branch August 26, 2022 17:31
cgayapr pushed a commit to cgayapr/openai-python that referenced this pull request Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants