fix(download): Fix download url by reverting change#197
Merged
hallacy merged 1 commit intoopenai:mainfrom Jan 25, 2023
Merged
Conversation
Contributor
|
%s and f strings have different formatting rules, but good catch on the url path! Might've accidentally deleted it |
Contributor
Author
interesting. whats the difference? |
hallacy
approved these changes
Jan 24, 2023
Collaborator
|
(will merge once the above conversation is resolved) |
Contributor
|
Ref: https://stackoverflow.com/questions/5082452/string-formatting-vs-format-vs-f-string-literal It's simply because of tuples and a few other things. (Take a look at flynt). I don't think it's applicable in this case in retrospect, so the change LGTM. |
davedittrich
pushed a commit
to davedittrich/openai-python
that referenced
this pull request
Jan 27, 2023
Co-authored-by: James Chua <james@leadiq.com>
Merged
cgayapr
pushed a commit
to cgayapr/openai-python
that referenced
this pull request
Dec 14, 2024
Co-authored-by: James Chua <james@leadiq.com>
safa0
pushed a commit
to safa0/openai-agents-python
that referenced
this pull request
Apr 27, 2025
LangChain employee/maintainer, happy to make edits to our docs/integrations if needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #196, and probably #185 and #183
This MR reverts the change in https://github.com/openai/openai-python/pull/146/files#r1084884786 so that the requests hit the
/contenturl of the api again.cc @Andrew-Chen-Wang @ddeville
To reproduce, on the older openai==0.25.0
`
You'll get the output of the actual CSV file
E.g.
step,elapsed_tokens,elapsed_examples,training_loss,training_sequence_accuracy,training_token_accuracy
1,22048,32,0.011019098009307718,0.0,0.0
1,32288,32,0.007613447834811513,0.0,0.0
On the current openai==0.26.2
You get instead
{
"object": "file",
"id": "file-66NnpqAXzw3In27fROPIU03P",
"purpose": "fine-tune-results",
"filename": "compiled_results.csv",
"bytes": 386756,
"created_at": 1674504271,
"status": "processed",
"status_details": null
}