fix(streaming): remove unreachable error check in thread event handler#3111
Open
armorbreak001 wants to merge 1 commit intoopenai:mainfrom
Open
fix(streaming): remove unreachable error check in thread event handler#3111armorbreak001 wants to merge 1 commit intoopenai:mainfrom
armorbreak001 wants to merge 1 commit intoopenai:mainfrom
Conversation
The condition inside the event branch is always False since "error" never starts with "thread.". This makes the error-handling block dead code. Remove the redundant predicate so that thread events carrying error payloads are properly caught and raised as APIError.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2796
In both
Stream.__stream__andAsyncStream.__stream__, the error handling block inside thethread.event branch contains the conditionsse.event == "error". Since this check is nested insideif sse.event.startswith("thread."), and the string"error"never starts with"thread.", this condition is alwaysFalse— making the entire error-handling block dead code.This appears to be a regression from a prior refactoring (mentioned in the issue as commit
abc25966) where the error check was incorrectly moved inside thethread.branch.Changes
sse.event == "error" andpredicate from the error condition in both sync and async stream handlersAPIErrorelsebranch is unchanged