[Fix] Fix audio api methods arguments not being considered#340
Closed
bnznamco wants to merge 1 commit intoopenai:mainfrom
Closed
[Fix] Fix audio api methods arguments not being considered#340bnznamco wants to merge 1 commit intoopenai:mainfrom
bnznamco wants to merge 1 commit intoopenai:mainfrom
Conversation
Collaborator
|
Closing this because #369 fixed it |
safa0
pushed a commit
to safa0/openai-agents-python
that referenced
this pull request
Apr 27, 2025
Previously the stream was closing as soon as all the audio was added but didn't wait for it to be finished. Additionally the audio might seem chopped off if there is no additional silence so this PR also adds one second of silence before exiting the program.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Methods of Audio package are not passing arguments to
cls.__prepare_request.This prevents to override the configuration of the client from the method.
Before:
After:
After this fix you will be able to override for example
api_keydirectly calling the method.