[deprecated]: remove unused/deprecated code#345
Conversation
* Remove unused variables and imports * Add some variables to `__all__` * Remove redundant parenthesis
GLEF1X
changed the title
hallacy
left a comment
hallacy
left a comment
There was a problem hiding this comment.
Wow! Thank you. Thats a ton of little details. How did you find all of these?
| @@ -392,7 +393,7 @@ def handle_error_response(self, rbody, rcode, resp, rheaders, stream_error=False | |||
| ) | |||
|
|
|||
| def request_headers( | |||
There was a problem hiding this comment.
Nit: can you check if the call in line 490 needs to get updated based on this?
There was a problem hiding this comment.
Yep, thank you for the review. It's indeed a bug that I overlooked. I've just fixed it in dc8feeb
I was using a couple of linters, and It's a good idea to integrate some into this project. For instance, I saw a pretty good configuration in evals, so contributors can follow the same code style. Tools like |
|
It's too bad this was never merged; the SDK has been entirely rewritten since. |
Towards openai#345 ## Summary: Using a `dict` or `Mapping` isn't strict-mode compliant. But we were checking for the literal `True` whereas the value can also be an array, for example. Fix that. ## Test Plan: Unit tests
3 participants
No description provided.