Pass in keyword arguments in embedding utility functions#405
Merged
hallacy merged 2 commits intoopenai:mainfrom Apr 19, 2023
Merged
Pass in keyword arguments in embedding utility functions#405hallacy merged 2 commits intoopenai:mainfrom
hallacy merged 2 commits intoopenai:mainfrom
Conversation
aelnosu
reviewed
Apr 19, 2023
aelnosu
left a comment
aelnosu
left a comment
There was a problem hiding this comment.
Debugging?
why remove
print(engine)
print(kwargs)
Contributor
Author
|
The print statements were added in my first commit for debugging purposes. They were not in the codebase in the first place. I forgot to remove them when pushing the first commit. That's why I removed them in a second commit. |
Understood thanks. |
1 task
cgayapr
pushed a commit
to cgayapr/openai-python
that referenced
this pull request
Dec 14, 2024
* Pass in kwargs in embedding util functions * Remove debug code
safa0
pushed a commit
to safa0/openai-agents-python
that referenced
this pull request
Apr 27, 2025
fix typo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The embedding utility functions currently only accept a minimum number of arguments. If a user needs to specify a few more keywords, that person can no longer use these functions, making them less useful than they could be. An example is shown in #392, in which an extra
request_timeoutargument can help bypass an unresolved bug.This PR solves this problem by adding
kwargsto all these utility functions.