Merged
Conversation
Contributor
Author
|
PR confirmed to be working by user. |
rachellim
approved these changes
Mar 28, 2022
Merged
cgayapr
pushed a commit
to cgayapr/openai-python
that referenced
this pull request
Dec 14, 2024
* feat(wandb): sanitize name * feat(wandb): ensure results are present
karpetrosyan
pushed a commit
to karpetrosyan/openai-python
that referenced
this pull request
Jul 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Datasets are saved as wandb artifacts using original file names.
However, some characters are not allowed to be used as artifact name.
This PR sanitizes the name used as wandb artifact.
It also ensures results are present even when a run is marked as
succeeded.