Skip to content

fix(acceptance/snapshots): use s3mock instead of localstack#162

Merged
pree merged 2 commits intoopenbao:mainfrom
pree:fix/move-to-ministack
Mar 26, 2026
Merged

fix(acceptance/snapshots): use s3mock instead of localstack#162
pree merged 2 commits intoopenbao:mainfrom
pree:fix/move-to-ministack

Conversation

@pree
Copy link
Copy Markdown
Member

@pree pree commented Mar 25, 2026

Description

With the deprecation of opensource localstack it's now requiring a license key to run.
A new (one day old) alternative would be MiniStack which is MIT licensed, or alternatively S3Mock from Adobe, which is Apache-2.0 licensed.

In this PR I'm changing it over to MiniStack S3Mock, but I'm still open for discussions which way we want to continue.

Checklist

  • This PR contains a description of the changes I'm making
  • I read the CONTRIBUTING.md guide
  • I updated the version in Chart.yaml if feasible according to Semantic versioning
  • I updated the changelog with an artifacthub.io/changes annotation in Chart.yaml
  • I update the changelog in CHANGELOG.md
  • I updated applicable README.md files using helm-docs
  • By contributing this change, I certify I have signed-off on the
    DCO ownership statement
    and this change did not use post-BUSL-licensed code from HashiCorp.
    Existing MPL-licensed code is still allowed, subject to attribution.
    Code authored by yourself and submitted to HashiCorp for inclusion is
    also allowed.

Signed-off-by: Pascal Reeb <pascal.reeb@secretz.io>
@pree
Copy link
Copy Markdown
Member Author

pree commented Mar 25, 2026

Ministack still failing inside the acceptance-<rnd> pod with:

WARNING: Retrying failed request: /bao_2026-03-25-2119.snapshot ([SSL] record layer failure (_ssl.c:1010))
WARNING: Waiting 3 sec...
WARNING: Retrying failed request: /bao_2026-03-25-2119.snapshot ([SSL] record layer failure (_ssl.c:1010))
WARNING: Waiting 6 sec...
WARNING: Retrying failed request: /bao_2026-03-25-2119.snapshot ([SSL] record layer failure (_ssl.c:1010))
WARNING: Waiting 9 sec...
WARNING: Retrying failed request: /bao_2026-03-25-2119.snapshot ([SSL] record layer failure (_ssl.c:1010))
WARNING: Waiting 12 sec...

This is due https on an http listener.

Signed-off-by: Pascal Reeb <pascal.reeb@secretz.io>
@pree pree changed the title fix(acceptance/snapshots): use ministack instead of localstack fix(acceptance/snapshots): use s3mock instead of localstack Mar 25, 2026
@pree pree marked this pull request as ready for review March 25, 2026 22:40
@pree pree requested review from a team as code owners March 25, 2026 22:40
@pree
Copy link
Copy Markdown
Member Author

pree commented Mar 25, 2026

@openbao/openbao-k8s-committers waiting on your input before merging this

@eyenx eyenx added no-release Used in PRs to not genearate a new release ci This issue is related to the CI/GitHub Worklow labels Mar 26, 2026
Copy link
Copy Markdown
Contributor

@eyenx eyenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. feel free to merge

@pree pree merged commit f2ca1ec into openbao:main Mar 26, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci This issue is related to the CI/GitHub Worklow no-release Used in PRs to not genearate a new release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants