fix(acceptance/snapshots): use s3mock instead of localstack#162
Merged
pree merged 2 commits intoopenbao:mainfrom Mar 26, 2026
Merged
fix(acceptance/snapshots): use s3mock instead of localstack#162pree merged 2 commits intoopenbao:mainfrom
pree merged 2 commits intoopenbao:mainfrom
Conversation
Signed-off-by: Pascal Reeb <pascal.reeb@secretz.io>
Member
Author
|
Ministack still failing inside the This is due https on an http listener. |
Signed-off-by: Pascal Reeb <pascal.reeb@secretz.io>
Member
Author
|
@openbao/openbao-k8s-committers waiting on your input before merging this |
JanMa
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With the deprecation of opensource localstack it's now requiring a license key to run.
A new (one day old) alternative would be MiniStack which is MIT licensed, or alternatively S3Mock from Adobe, which is Apache-2.0 licensed.
In this PR I'm changing it over to
MiniStackS3Mock, but I'm still open for discussions which way we want to continue.Checklist
CONTRIBUTING.mdguideChart.yamlif feasible according to Semantic versioningartifacthub.io/changesannotation inChart.yamlCHANGELOG.mdREADME.mdfiles using helm-docsDCO ownership statement
and this change did not use post-BUSL-licensed code from HashiCorp.
Existing MPL-licensed code is still allowed, subject to attribution.
Code authored by yourself and submitted to HashiCorp for inclusion is
also allowed.