Skip to content

Add OCM artifact for OpenBao#75

Merged
pree merged 9 commits intoopenbao:mainfrom
Ki-Reply-GmbH:feat/add_ocm_artifact
Sep 12, 2025
Merged

Add OCM artifact for OpenBao#75
pree merged 9 commits intoopenbao:mainfrom
Ki-Reply-GmbH:feat/add_ocm_artifact

Conversation

@voigt
Copy link
Copy Markdown
Member

@voigt voigt commented Jul 10, 2025

This PR addresses #74 and adds a Github Action job to create an OCM artifact for OpenBao referencing the OpenBao upstream helm-chart.

The OCM job will be triggered after a release of the helm chart is performed.

Artifact signing is not yet part of this PR. We'd like to use our existing GPG key we use to sign all other artifacts. Unfortunately OCM does not yet support signing via a passkey protected key (see #1544).

@voigt voigt requested review from a team as code owners July 10, 2025 09:28
@voigt voigt force-pushed the feat/add_ocm_artifact branch 4 times, most recently from b43bc26 to 102f93e Compare July 10, 2025 11:36
@pree
Copy link
Copy Markdown
Member

pree commented Jul 10, 2025

@voigt Thanks already for the PR! Please open PR's as draft PRs (especially when your working on it) and press Ready for review once the actions are green and it's ready for review, as we are then notified that this PR is ready and don't receive a bunch of mails before :) I think we could add this approach to CONTRIBUTING.md too.

@voigt voigt marked this pull request as draft July 10, 2025 11:48
@voigt
Copy link
Copy Markdown
Member Author

voigt commented Jul 10, 2025

Good point - I simply haven't thought of that option. Sorry for spamming your inbox 😇

@voigt voigt force-pushed the feat/add_ocm_artifact branch 2 times, most recently from 2f11eb5 to 5796a4c Compare July 10, 2025 12:00
@voigt voigt marked this pull request as ready for review July 10, 2025 12:01
@voigt
Copy link
Copy Markdown
Member Author

voigt commented Jul 11, 2025

@cipherboy / @pree would either of you be able to store the signing material as secrets.OCM_SIGNING_KEY_PRIV in Github Secrets of this project?

https://ocm.software/docs/getting-started/sign-component-versions/

@pree
Copy link
Copy Markdown
Member

pree commented Jul 14, 2025

@cipherboy / @pree would either of you be able to store the signing material as secrets.OCM_SIGNING_KEY_PRIV in Github Secrets of this project?

https://ocm.software/docs/getting-started/sign-component-versions/

Alex put the signing key as secrets.GPG_PRIVATE_KEY and secrets.GPG_PRIVATE_KEY_BASE64 with the password as secrets.GPG_PASSWORD

@voigt voigt marked this pull request as draft July 14, 2025 08:40
@voigt voigt force-pushed the feat/add_ocm_artifact branch 3 times, most recently from ce218d0 to 1782c77 Compare July 14, 2025 08:48
@voigt voigt force-pushed the feat/add_ocm_artifact branch 3 times, most recently from 463fc10 to f0902d6 Compare July 14, 2025 12:49
@voigt voigt force-pushed the feat/add_ocm_artifact branch 2 times, most recently from 71f5eba to b5ede93 Compare August 21, 2025 13:57
JanMa
JanMa previously requested changes Aug 21, 2025
Copy link
Copy Markdown
Member

@JanMa JanMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@voigt looking at the error message, the GitHub Actions workflow is trying to push to a non existing package in the GitHub registry:

Error: openbao.org/openbao:0.16.3: transferring resource 0: unable to add blob (component openbao.org/openbao:0.16.3 resource openbao-helm-chart-external-oci): exploding OCI artifact resource blob ([openbao/charts/openbao:0.16.3] namespace openbao/openbao/charts/openbao: transfer artifact): transferring config blob: unable to add blob (OCI repository openbao/openbao/charts/openbao): failed to push: failed to push: POST "https://ghcr.io/v2/openbao/openbao/charts/openbao/blobs/uploads/": response status code 403: denied: installation not allowed to Create organization package, ghcr.io/openbao/openbao/charts/openbao

The correct path would be ghcr.io/openbao/charts/openbao. I am not yet sure which setting needs to be changed in the OCM config to get rid of the additional openbao in the path 🤔

Signed-off-by: Christoph Voigt <christoph.voigt@sap.com>
Signed-off-by: Christoph Voigt <christoph.voigt@sap.com>
Signed-off-by: Christoph Voigt <christoph.voigt@sap.com>
Signed-off-by: Christoph Voigt <christoph.voigt@sap.com>
Signed-off-by: Christoph Voigt <christoph.voigt@sap.com>
Signed-off-by: Christoph Voigt <christoph.voigt@sap.com>
Signed-off-by: Christoph Voigt <christoph.voigt@sap.com>
@phyrog phyrog force-pushed the feat/add_ocm_artifact branch from b5ede93 to 985f121 Compare September 9, 2025 07:01
@phyrog
Copy link
Copy Markdown
Contributor

phyrog commented Sep 9, 2025

@JanMa @pree Can one of you with the right permissions try to trigger the failed job again? I think I fixed the ghcr.io path now, but I don't have permissions to push the artifacts.

@eyenx
Copy link
Copy Markdown
Contributor

eyenx commented Sep 9, 2025

@JanMa @pree Can one of you with the right permissions try to trigger the failed job again? I think I fixed the ghcr.io path now, but I don't have permissions to push the artifacts.

Done

@pree
Copy link
Copy Markdown
Member

pree commented Sep 9, 2025

I think this needs to be merged to be able to run using the repository GH secrets

@phyrog
Copy link
Copy Markdown
Contributor

phyrog commented Sep 9, 2025

I will try this out in our fork repo and update it to only trigger on releases when everything else is working

@phyrog phyrog force-pushed the feat/add_ocm_artifact branch 4 times, most recently from 8d3aa88 to 7435426 Compare September 9, 2025 12:07
@phyrog
Copy link
Copy Markdown
Contributor

phyrog commented Sep 9, 2025

@pree @JanMa This should be done now. This is what it looks like in our forked repo: https://github.com/Ki-Reply-GmbH/openbao-helm/pkgs/container/component-descriptors%2Fopenbao.org%2Fopenbao so the artifact would be stored under ghcr.io/openbao/component-descriptors/openbao.org/openbao:<tag>.

This now only builds and pushes the OCM artifact itself, all the actual artifacts (helm chart + images) are just being referenced.

Unfortunately since it's not my PR I can't undraft it.

@pree pree marked this pull request as ready for review September 9, 2025 12:23
@pree
Copy link
Copy Markdown
Member

pree commented Sep 9, 2025

Thanks for the update!

Unfortunately since it's not my PR I can't undraft it.

I've just undrafted the PR for you :)

Signed-off-by: Tom Gehrke <tom.gehrke@sap.com>
@phyrog phyrog force-pushed the feat/add_ocm_artifact branch from 7435426 to 5c841fb Compare September 10, 2025 11:18
@phyrog phyrog requested review from JanMa and pree September 10, 2025 14:31
Signed-off-by: Tom Gehrke <tom.gehrke@sap.com>
@phyrog phyrog force-pushed the feat/add_ocm_artifact branch from 5c841fb to bfe54b2 Compare September 11, 2025 08:28
Copy link
Copy Markdown
Member

@pree pree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the first iteration.

I would love to have this swapped out for a OCM GH Action when this will be available sometime in the future.

@pree pree dismissed JanMa’s stale review September 11, 2025 14:59

Let's see if it works after merging :)

@pree pree merged commit 149d9a3 into openbao:main Sep 12, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants