Align track view button placement with thumbnail view#1158
Merged
Conversation
Makes the button in the track selection view behave more
similar to how the thumbnail generation buttons behave.
Since there's only one button ("Delete Track"),
I'm a little worried if it still parses as a button without a border.
|
This pull request is deployed at test.editor.opencast.org/1158/2023-09-14_08-10-25/ . |
owi92
approved these changes
Oct 26, 2023
Contributor
owi92
left a comment
owi92
left a comment
There was a problem hiding this comment.
Looks good to me.
One thing I noticed when looking at these buttons is that their icon color isn't inverted on hover in high contrast modes. But that's neither introduced by nor subject of this PR - I'll open a separate issue.
|
This pull request has conflicts ☹ |
github-actions
Bot
added
the
status:conflicts
github-actions
Bot
removed
the
status:conflicts
|
This pull request is deployed at test.editor.opencast.org/1158/2023-11-01_09-13-03/ . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the button in the track selection view behave more similar to how the thumbnail generation buttons behave.
Since there's only one button ("Delete Track"),
I'm a little worried if it still parses as a button without a border.
Aims to resolve #1157.