Skip to content

Controls to jump to next or previous segment#1317

Merged
lkiesow merged 4 commits into
opencast:mainfrom
dennis531:jump-segment
May 6, 2024
Merged

Controls to jump to next or previous segment#1317
lkiesow merged 4 commits into
opencast:mainfrom
dennis531:jump-segment

Conversation

@dennis531
Copy link
Copy Markdown
Collaborator

Add the mentioned controls in #1283.

The controls are deactivated on the subtitle interface, as in my opinion the function is not needed here.

Screenshot with the controls:
image

@dennis531 dennis531 added the type:feature A new feature or feature request label Apr 22, 2024
@dennis531 dennis531 self-assigned this Apr 22, 2024
@github-actions
Copy link
Copy Markdown

This pull request is deployed at test.editor.opencast.org/1317/2024-04-22_12-00-33/ .
It might take a few minutes for it to become available.

@lkiesow
Copy link
Copy Markdown
Member

lkiesow commented Apr 25, 2024

I found two problems with this:

  1. When I'm in the middle of a segment and hit “jump back”, I would expect the end up at the start of the segment, not at the start of the previous segment. Or in other works, I would expect to jump to the next or last cut mark
  2. I cannot jump while the video is playing
opencast-editor-jump-segment.mp4

@dennis531 dennis531 removed their assignment Apr 26, 2024
@kai-wng-uos
Copy link
Copy Markdown
Collaborator

I agree with @lkiesow
that is also how it works in all media players I have used. maybe we should change the wording to "zum letzten Schnitt springen"

@github-actions
Copy link
Copy Markdown

This pull request is deployed at test.editor.opencast.org/1317/2024-04-26_09-14-05/ .
It might take a few minutes for it to become available.

@dennis531
Copy link
Copy Markdown
Collaborator Author

dennis531 commented Apr 26, 2024

I found two problems with this:

  1. When I'm in the middle of a segment and hit “jump back”, I would expect the end up at the start of the segment, not at the start of the previous segment. Or in other works, I would expect to jump to the next or last cut mark

  2. I cannot jump while the video is playing

opencast-editor-jump-segment.mp4

I fixed the mentioned problems.

to 1: I added a 3 second threshold at the beginning of the segment as it was not possible to jump back to the next video when the playback is active. For the duration, I oriented myself on spotify's "jump back" function.

that is also how it works in all media players I have used. maybe we should change the wording to "zum letzten Schnitt springen"

I think we should change the wording too. Alternatively, we could provide a more general label like "Jump back" without explicitly mention the target. Especially with the treshhold, I'm not sure if your suggestion still fits.

@kai-wng-uos
Copy link
Copy Markdown
Collaborator

looks good to me now, Thanks @dennis531! As for the wording: I think a simple back/ forward might suffice. Users are already used to this wording with other media players.

@github-actions
Copy link
Copy Markdown

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@github-actions github-actions Bot added the status:conflicts Conflicts with another pull request or issue label Apr 26, 2024
@KatrinIhler
Copy link
Copy Markdown
Member

Conflicts. :(

Dennis Benz added 3 commits April 26, 2024 14:16
Allow to jump when video player is playing. If current time is in the middle of the active segment, jump back to the beginning of this segment.
@github-actions github-actions Bot removed the status:conflicts Conflicts with another pull request or issue label Apr 26, 2024
@github-actions
Copy link
Copy Markdown

This pull request is deployed at test.editor.opencast.org/1317/2024-04-26_12-25-11/ .
It might take a few minutes for it to become available.

@github-actions
Copy link
Copy Markdown

This pull request is deployed at test.editor.opencast.org/1317/2024-04-26_15-32-25/ .
It might take a few minutes for it to become available.

@lkiesow
Copy link
Copy Markdown
Member

lkiesow commented May 6, 2024

Looks good. I have a suggestion for a minor improvement for the 3 seconds threshold, but I'll file a separate pull request for that.

@lkiesow lkiesow self-assigned this May 6, 2024
@lkiesow lkiesow merged commit fbae57c into opencast:main May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:feature A new feature or feature request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants