Skip to content

Metadata#214

Merged
lkiesow merged 13 commits into
opencast:mainfrom
Arnei:metadata
Mar 24, 2021
Merged

Metadata#214
lkiesow merged 13 commits into
opencast:mainfrom
Arnei:metadata

Conversation

@Arnei
Copy link
Copy Markdown
Member

@Arnei Arnei commented Mar 10, 2021

This PR allows the user to edit metadata of an event. Resolves #199

  • Enables a main menu item for metadata.
  • Gets metadata from Opencast
  • Displays Metadata in a form that allows for changes
  • Sends metadata to Opencast

TODOs:

  • Start "Republish metadata" in Opencast if necessary?
  • Get rid of error message in console
  • Automatic validation of date type form entries

This commit allows the user to edit metadata of any event
@github-actions
Copy link
Copy Markdown

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@github-actions github-actions Bot added the status:conflicts Conflicts with another pull request or issue label Mar 10, 2021
@github-actions
Copy link
Copy Markdown

This pull request is deployed at test.editor.opencast.org/214/2021-03-10_11-47-31/ .
It might take a few minutes for it to become available.

@github-actions github-actions Bot removed the status:conflicts Conflicts with another pull request or issue label Mar 10, 2021
@github-actions
Copy link
Copy Markdown

This pull request is deployed at test.editor.opencast.org/214/2021-03-10_11-55-30/ .
It might take a few minutes for it to become available.

@github-actions
Copy link
Copy Markdown

This pull request is deployed at test.editor.opencast.org/214/2021-03-10_14-52-32/ .
It might take a few minutes for it to become available.

@lkiesow
Copy link
Copy Markdown
Member

lkiesow commented Mar 10, 2021

  • Do we want fields like “Presenter” to be a drop-down? Or a simple text field? I think the latter may make more sense and cause less problems.
  • How do we handle fields with multiple entries (again thinking of presenter)

@github-actions
Copy link
Copy Markdown

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@github-actions github-actions Bot added the status:conflicts Conflicts with another pull request or issue label Mar 11, 2021
@Arnei
Copy link
Copy Markdown
Member Author

Arnei commented Mar 12, 2021

* Do we want fields like “Presenter” to be a drop-down? Or a simple text field? I think the latter may make more sense and cause less problems.

Ideally we probably want it to be both a drop-down and an input field, similar to the Admin-UI. I personally do like the quasi-autocomplete functionality this leads to. But might be more error prone.

* How do we handle fields with multiple entries (again thinking of presenter)

Hoping no one ever tries to use multiple entries is not an option, is it? In that case, we again probably want it work similarly to how it currently works in the Admin-UI (Display multiple values, allow removing exisiting values, onEdit also show an input/select element to add new elements)

@github-actions github-actions Bot removed the status:conflicts Conflicts with another pull request or issue label Mar 12, 2021
@github-actions
Copy link
Copy Markdown

This pull request is deployed at test.editor.opencast.org/214/2021-03-12_10-31-41/ .
It might take a few minutes for it to become available.

@github-actions
Copy link
Copy Markdown

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@github-actions github-actions Bot added the status:conflicts Conflicts with another pull request or issue label Mar 12, 2021
- Can select multiple values
- Can add your own values
- There is currently a bug where the form does not correctly reflect the update after submit
@github-actions
Copy link
Copy Markdown

This pull request is deployed at test.editor.opencast.org/214/2021-03-12_14-34-25/ .
It might take a few minutes for it to become available.

- Resets the form after submit
- Causes ugly flicker
@github-actions
Copy link
Copy Markdown

This pull request is deployed at test.editor.opencast.org/214/2021-03-12_14-56-29/ .
It might take a few minutes for it to become available.

@github-actions github-actions Bot removed the status:conflicts Conflicts with another pull request or issue label Mar 15, 2021
@github-actions
Copy link
Copy Markdown

This pull request is deployed at test.editor.opencast.org/214/2021-03-15_10-52-20/ .
It might take a few minutes for it to become available.

@github-actions
Copy link
Copy Markdown

This pull request is deployed at test.editor.opencast.org/214/2021-03-15_11-54-20/ .
It might take a few minutes for it to become available.

@lkiesow
Copy link
Copy Markdown
Member

lkiesow commented Mar 17, 2021

Make changes as you like, then hit the Submit button.
Note that you will still have to start processing for your changes to take effect.

The first like is pretty meaningless and from what I can tell, they take effect immediately. Just not for publications.

Note that updated metadata are not immediately published.
You need to start a workflow to update publications.

Also, I would probably call the button „Save“ and the title „Save your changes“.


You also lose some metadata when switching between views:

editor-metadata-disappear.mp4

Finally, I'm not sure where the „metadata.Arnes Metadaten“ come from. Are these already extended metadata?

@Arnei
Copy link
Copy Markdown
Member Author

Arnei commented Mar 17, 2021

The first like is pretty meaningless and from what I can tell, they take effect immediately. Just not for publications.

Yes, changes are immediately saved to Opencast when hitting "Submit". But users may not understand the difference between "saved to Opencast" and "saved to publications". So I wanted to give users a hint that even though they hit "Submit" (or "Save"), they would still need to select a processing step for their changes to become effective in their Moodle-Video or whatever. Seems like I should mull some more over the wording.

Also, I would probably call the button „Save“ and the title „Save your changes“.

Left this as "Submit" to avoid confusion with the "Save" button in the "Finish" menu (since they do different things).

You also lose some metadata when switching between views:

That is weird, good catch.

Finally, I'm not sure where the „metadata.Arnes Metadaten“ come from. Are these already extended metadata?

Yup, that's already an extended metadata catalog. Excuse me restarting pyca.opencast.org a couple of times during your testing.

@lkiesow
Copy link
Copy Markdown
Member

lkiesow commented Mar 17, 2021

Left this as "Submit" to avoid confusion with the "Save" button in the "Finish" menu (since they do different things).

Don't both save data to the asset manager?
But maybe a bit more explicit: “Save metadata”

@lkiesow
Copy link
Copy Markdown
Member

lkiesow commented Mar 17, 2021

Or maybe even remove the submit button and just use the save button in the finish view.
That way, you also have no conflicts with the “Discard changes” functionality which will not discard these changes at all.

Arnei added 2 commits March 18, 2021 09:19
- Added support for checkboxes, textareas and time pickers (which don't work in opencast)
- Fixed translation when there is no translation
- Submits now onBlur
- Visual feedback for submit
- Does not automatically dispatch anymore. Dispatch now happens in the save part.
@github-actions
Copy link
Copy Markdown

This pull request is deployed at test.editor.opencast.org/214/2021-03-18_13-22-08/ .
It might take a few minutes for it to become available.

@Arnei
Copy link
Copy Markdown
Member Author

Arnei commented Mar 18, 2021

Or maybe even remove the submit button and just use the save button in the finish view.
That way, you also have no conflicts with the “Discard changes” functionality which will not discard these changes at all.

I went ahead and implemented it this way. This is closest to how it works in the Admin-UI as well.

@github-actions
Copy link
Copy Markdown

This pull request is deployed at test.editor.opencast.org/214/2021-03-22_15-54-16/ .
It might take a few minutes for it to become available.

@lkiesow lkiesow merged commit c4e82ff into opencast:main Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow editing DC metadata

2 participants