Skip to content

Padding for long button labels#650

Merged
lkiesow merged 2 commits into
opencast:mainfrom
narickmann:padding
Jun 17, 2022
Merged

Padding for long button labels#650
lkiesow merged 2 commits into
opencast:mainfrom
narickmann:padding

Conversation

@narickmann
Copy link
Copy Markdown
Contributor

This fixes #649
Added some padding left and right.

Editor-padding

This fixes #649
Added some padding left and right.
@github-actions
Copy link
Copy Markdown

This pull request is deployed at test.editor.opencast.org/650/2022-03-22_12-56-27/ .
It might take a few minutes for it to become available.

@Arnei
Copy link
Copy Markdown
Member

Arnei commented Mar 22, 2022

Maybe this is just me being used to the current button size, but I don't like the increased width. Could we instead pad without the width increase?

@narickmann
Copy link
Copy Markdown
Contributor Author

Could we instead pad without the width increase?

So do you mean by line break?

@Arnei
Copy link
Copy Markdown
Member

Arnei commented Mar 22, 2022

The text already wraps, but will only do so fairly late in the original code. It would be better to cause the text wrap before it almost hits the edges of the button. Your patch does that, but also causes the button to increase in visible width which I find undesirable.

Added padding to button-text directly instead to the buttons. So the button size does not increase and the text does not almost hit the edges of the buttons.
@github-actions
Copy link
Copy Markdown

This pull request is deployed at test.editor.opencast.org/650/2022-06-15_10-40-51/ .
It might take a few minutes for it to become available.

@lkiesow
Copy link
Copy Markdown
Member

lkiesow commented Jun 17, 2022

Looks good:

``

@lkiesow lkiesow self-assigned this Jun 17, 2022
@lkiesow lkiesow added the type:visual-clarity A part of the UI is not visually readable label Jun 17, 2022
@lkiesow lkiesow changed the title Padding added Padding for long button labels Jun 17, 2022
@lkiesow lkiesow merged commit bc1d2bb into opencast:main Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:visual-clarity A part of the UI is not visually readable

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Padding for long words

3 participants