make TrackSelection respect theme selection for menu headings#768
Merged
Conversation
|
This pull request is deployed at test.editor.opencast.org/768/2022-08-30_15-07-48/ . |
Member
Author
|
You may wanna squash those two commits before merging... :) |
Arnei
approved these changes
Sep 5, 2022
Member
Arnei
left a comment
Arnei
left a comment
There was a problem hiding this comment.
I was wondering if there had been a line there in the past or if I just imagined it, but it seems there was a line after all! Thanks for bringing it back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CSS property
border-bottomfor the menu headings on the Track Selection was hard coded to1px solid white, which works great for the dark theme, but not so much for the light theme.Before:
After:
