change cursor style to text for react-select multi CreatableSelect#796
Conversation
The presenter and contributor fields in the metadata tab use a combined select input control with multi-select enabled. The actual <input> is only a few pixels wide, so when hovering over the control, it's not showing a text cursor indicating the possibility to input new text. This commit sets the cursor on the `valueContainer` component to `text` and resets it to `default` on the `multiValue` component. For the list of available components for React-Select see: https://react-select.com/components Fixes: opencast#785 Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
|
Nice, thanks for fixing this. While you're at it, could you take a look at the dark mode for the multi-select component? The text cursor is hardly visible in dark mode, which seems to be due to the text color being wrong in general (dark grey instead of the expected white). |
|
Why is this PR not deployed on test.editor.opencast.org? |
The github action is currently hardcoded to only work for PRs from certain repos (there are more lines than in the preview): https://github.com/opencast/opencast-editor/blob/2a17c13bd814db30f987952cbfe91ee59dfd601b/.github/workflows/update-test.yml#L12. Would make sense to extend this to all Opencast committers, I think we just kind of forgot about it. |
|
I would fix the text cursor in the dark mode in a new PR. |
|
Created an issue so we don't forget #813 |
@Arnei any suggestion on how to reasonably update the workflow? I do not want to add all commiters manually and not update it automatically. Is there any way to check for the members of the developer team? |
Tbh I do not know how to do this in a smart way, would have to look into it myself. @lkiesow might have an idea? |
2 participants
The presenter and contributor fields in the metadata tab use a combined select input control with multi-select enabled. The actual is only a few pixels wide, so when hovering over the control, it's not showing a text cursor indicating the possibility to input new text.
This commit sets the cursor on the
valueContainercomponent totextand resets it todefaulton themultiValuecomponent.For the list of available components for React-Select see: https://react-select.com/components
Fixes: #785