Icon Configuration for Languages#860
Conversation
lkiesow
added
type:visual-clarity
|
This pull request is deployed at test.editor.opencast.org/860/2022-10-28_17-01-49/ . |
Arnei
left a comment
Arnei
left a comment
There was a problem hiding this comment.
I agree with this PR. Correctly guessing all the language flags was a pipe dream anyway.
This also allows us to avoid the discussion whether country flags are sensible indicators for languages, which is nice.
Comments below are justodds and ends.
| "captions/source+es" = "Spanish" | ||
|
|
||
| [subtitles.icons] | ||
| # A list of icons to be displayed for languages defined above. |
There was a problem hiding this comment.
We could mention that these are totally optional? Arguably that might be obvious, but it might also not be. And in that case, no one feels pressured into thinking up icons when they don't want.
Alternatively comment the list out?
There was a problem hiding this comment.
I'll update the description
|
One more comment: Since the "icons" can now be very long, it might make sense to update the icon css a bit, although I hope we can trust people who are allowed to set the config to choose sensible values :) |
|
This pull request is deployed at test.editor.opencast.org/860/2022-11-11_22-31-11/ . |
|
This pull request is deployed at test.editor.opencast.org/860/2022-11-11_22-32-12/ . |
I kind of feel like saying that if people want to be stupid, let them be stupid ;-) |
Yes, thinking about exactly that. Wouldn't spent any major on time this though if |
lkiesow
force-pushed
the
language-icons
branch
from
c722f7a to
5d3bf00
Compare
|
Updated the style. If you now try adding hundreds of flags, you will end up with something like this:
|
This patch allows users to specify icons for languages selectors displayed in the subtitle editor. Users have to specify the selectable languages anyway and the algorithm used before guessed wrong for popular languages like English. If no icon is specified for a language, the selector will simply omit the icon and display just the label. This fixes opencast#825
lkiesow
force-pushed
the
language-icons
branch
from
5d3bf00 to
02940b1
Compare
|
This pull request is deployed at test.editor.opencast.org/860/2022-11-23_18-55-28/ . |
2 participants
This patch allows users to specify icons for languages selectors displayed in the subtitle editor. Users have to specify the selectable languages anyway and the algorithm used before guessed wrong for popular languages like English.
If no icon is specified for a language, the selector will simply omit the icon and display just the label.
This fixes #825