fix(windows): support .cmd/.bat agent commands#102
Merged
vincentkoc merged 3 commits intoopenclaw:mainfrom Mar 11, 2026
Merged
Conversation
lynnzc
changed the title
vincentkoc
added a commit
to MikeChongCan/acpx
that referenced
this pull request
Mar 11, 2026
…-gemini-version-check * origin/main: fix(windows): support .cmd/.bat agent commands (openclaw#102) chore(deps-dev): bump @typescript/native-preview (openclaw#107) chore(deps-dev): bump tsdown from 0.21.0-beta.2 to 0.21.0 (openclaw#106) fix: validate structured image prompt blocks (openclaw#110) chore: switch releases to tag-based publishing chore: bump version to 0.2.0 # Conflicts: # src/client.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes Windows agent command spawning for batch wrappers (
.cmd/.bat) such asnpx.cmd.child_process.spawn(..., { shell: false })cannot execute Windows batch files directly, so ACPX failed with spawn errors in those cases.What changed
shouldUseWindowsBatchShell(command, platform)to detect Windows batch wrappers.buildSpawnCommandOptions(command, options, platform)to enableshell: trueonly when needed (win32+.cmd/.bat).src/client.ts.test/spawn-options.test.tsfor:.cmd/.baton Windows =>shellenabled.shellremains disabled.Why this approach
Testing
Fully tested locally:
pnpm checkpnpm run build:testnode --test dist-test/test/spawn-options.test.js dist-test/test/client.test.jsIssue
Closes #90