Conversation
|
@osolmaz could you take a look when you have a chance? This adds built-in Qoder ACP support plus the small runtime/session persistence compatibility needed for real |
Triage resultHuman attention: Quick read
IntentThis PR adds first-class built-in Qoder ACP support to Why
Codex review
CI/CD
RecommendationThis is ready for human landing decision. The implementation is right-shaped for the feature, the conflict gates are clean, targeted validation passed, and CI is green. The remaining Codex notes are P2/P3 and do not block merge unless you want those edge cases tightened before landing. |
231edaf to
f15d736
Compare
|
Landed via temp rebase onto main.\n\n- Gate: validation completed for this repo's change scope\n- Land commit: f15d736\n- Merge commit: d5ac799\n\nThanks @xinyuan0801! |
Summary
qoder -> qodercli --acpsupport and sync the neutral built-in docs surfacesAcpClientfor clean ACP stdio runs and Qoder CLI startup flag forwardingsession/loadrecoveryWhy
Qoder CLI already supports ACP over stdio, but
acpxdid not have a built-in entrypoint for it.Real local ACP smoke also exposed two gaps: Qoder emits benign non-JSON shutdown chatter after successful runs, and Qoder-native startup flags derived from
acpxsession options would disappear after persistent session reuse unless they were stored in the session record.This change makes
acpx qoder ...work out of the box without adding new generic CLI conventions.Validation
pnpm run checkpnpm run check:docsqoderclismoke forexec, JSON output,--file, named-session reuse,history,status,set-mode,cancel,--no-wait,approve-reads, andsession/loadrecoveryAI-assisted and fully tested locally.