Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f70e5e7c6a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (commandToken === "codex-acp") { | ||
| return true; | ||
| } | ||
| return args.some((arg) => arg.includes("codex-acp")); |
There was a problem hiding this comment.
Recognize codex-acp script paths as Codex sessions
isCodexAcpCommand only treats a command as Codex when the basename is exactly codex-acp (with only .cmd/.exe/.bat stripped) or when an argument contains codex-acp. If agents.codex.command is configured to a direct script path like /opt/tools/codex-acp.js with no extra args, this check returns false, so AcpClient.createSession never sends session/set_config_option for model and --model is silently ignored for that Codex setup.
Useful? React with 👍 / 👎.
Summary
--modelaftersession/newviasession/set_config_optionmainContext
This PR supersedes #128 only because the original fork branch could not be updated from this maintainer environment even though the PR was marked editable.
Original author and core fix: @Asm3r96
Original PR: #128
Validation
pnpm run check:docsprompt reconciles agentSessionId from loadSession metadatapnpm run test:coverageandpnpm run checkstill hit the same repo-local coverage baseline failure seen onmainin this environment under the only installed local Node runtime, so they are not useful as change-specific signal here