fix(windows): improve CLI startup and build script compatibility#36
Open
mathiasbarea wants to merge 1 commit intoopenclaw:mainfrom
Open
fix(windows): improve CLI startup and build script compatibility#36mathiasbarea wants to merge 1 commit intoopenclaw:mainfrom
mathiasbarea wants to merge 1 commit intoopenclaw:mainfrom
Conversation
|
I encounter the same issue and I can confirm this fix works on my computer. Hopefully this may help this PR gets merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves Windows compatibility in two places:
bin/lobster.jspathToFileURL(...).hreffor dynamic imports so the CLI starts correctly on Windows under Node ESMpackage.jsonrm -rf distwith a Node-based cleanup commandpnpm exec tscWhy
Before this change, Lobster failed to start correctly on Windows because the CLI entrypoint used dynamic
import()with absolute filesystem paths. Under Node ESM on Windows, raw paths likeC:\...are not valid module specifiers and caused:ERR_UNSUPPORTED_ESM_URL_SCHEMEThis affected multiple commands, including:
node ./bin/lobster.js --helpnode ./bin/lobster.js doctorlobster run --file ...In addition, the existing
cleanandbuildscripts were not portable to Windows shells.Tested on Windows
node ./bin/lobster.js --helpnode ./bin/lobster.js doctorlobster run --file ...These now work correctly.