This repository was archived by the owner on Aug 2, 2022. It is now read-only.
Publish latency and failure metrics for cluster state applier thread#563
Merged
yu-sun-77 merged 6 commits intoMar 17, 2021
Merged
Publish latency and failure metrics for cluster state applier thread#563yu-sun-77 merged 6 commits into
yu-sun-77 merged 6 commits into
Conversation
Comment on lines
+826
to
+828
| /** | ||
| * Sum of total pending tasks throttled by master node. | ||
| */ |
There was a problem hiding this comment.
Is this a copy-paste miss? The comment seems to be unrelated.
| AllMetrics.ClusterApplierServiceStatsValue.CLUSTER_APPLIER_SERVICE_LATENCY.toString(), | ||
| new MetricAttributes( | ||
| MetricUnits.MILLISECOND.toString(), EmptyDimension.values())); | ||
|
|
There was a problem hiding this comment.
Don't we need to include failure metric as well in here?
yu-sun-77
reviewed
Mar 15, 2021
| CLUSTER_APPLIER_SERVICE, | ||
| ADMISSION_CONTROL_METRICS, | ||
| SHARD_INDEXING_PRESSURE | ||
| SHARD_INDEXING_PRESSURE; |
Contributor
There was a problem hiding this comment.
Can we replace ";" with "," to avoid future changes when adding new metric?
yu-sun-77
reviewed
Mar 15, 2021
| @@ -0,0 +1,25 @@ | |||
| /* | |||
| * Copyright 2019 Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
Contributor
There was a problem hiding this comment.
Can we change year to 2021 in the license header?
yu-sun-77
approved these changes
Mar 16, 2021
nitinverma2510
approved these changes
Mar 17, 2021
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #, if available: 564
Description of changes: With this change we will start publishing metrics like Latency and failure for Cluster state applier thread.
1.Tested using Docker
Tmp file
Table created
Contents of the table