fix: Don't filter out extras for a pip dependency.#377
Merged
Conversation
feanil
force-pushed
the
feanil/fix_update_py_sh_script
branch
from
303a9e4 to
ad307cf
Compare
rgraber
suggested changes
Aug 7, 2023
Contributor
rgraber
left a comment
rgraber
left a comment
There was a problem hiding this comment.
We should update python-template/setup.py as well so new repos get the correct regex.
Also can you document the tests you ran and what the difference was in output between the old and the new scripts?
Before this change, the function was dropping extra dependencies. For example: If you had a requirements file like the following: ``` Xblock[django] ``` It will output: `Xblock` The correct output should be `Xblock[django]` This drops the extras which may have further constraint requirements or more packages that are required. In the example, the package would need Django but that dependency would not be visible upstream correctly.
feanil
force-pushed
the
feanil/fix_update_py_sh_script
branch
from
ad307cf to
c340961
Compare
Contributor
Author
|
@rgraber I made the update to setup.py, for testing, I updated the description and commit message to make it more clear what the test looks like. The example is from the test I actually ran, let me know if you are looking for something else or if that's sufficient documentation of testing. |
5 tasks
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, the function was dropping extra dependencies. For
example:
If you had a requirements file like the following:
It will output:
XblockThe correct output should be
Xblock[django]This drops the extras which may have further constraint requirements or
more packages that are required. In the example, the package would need
Django but that dependency would not be visible upstream correctly.