Merged
Conversation
These redis methods don't timeout and can cause infinite hangs when redis goes down while reading the pending messages. We wrap them in our own timeouts now and make those trigger consumer restarts to force reconnects and prevent the hangs.
bmtcril
force-pushed
the
bmtcril/add_pending_msg_timeouts
branch
from
558f9de to
326fbc1
Compare
Ian2012
approved these changes
Oct 3, 2024
navinkarkera
approved these changes
Oct 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These redis methods don't timeout and can cause infinite hangs when redis goes down while reading the pending messages. We wrap them in our own timeouts now and make those trigger consumer restarts to force reconnects and prevent the hangs.