Skip to content

chore: Add support for Django 5.2#165

Merged
bmtcril merged 3 commits intomainfrom
bmtcril/upgrade_django52
Apr 8, 2025
Merged

chore: Add support for Django 5.2#165
bmtcril merged 3 commits intomainfrom
bmtcril/upgrade_django52

Conversation

@bmtcril
Copy link
Copy Markdown
Contributor

@bmtcril bmtcril commented Apr 8, 2025

Closes #163

Ran django-upgrade, which made one change in __init__.py, see PR comment.

Merge checklist:

  • All reviewers approved
  • CI build is green
  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Commits are squashed

@bmtcril bmtcril requested a review from saraburns1 April 8, 2025 13:49
@bmtcril bmtcril force-pushed the bmtcril/upgrade_django52 branch from dd97627 to 94a1d53 Compare April 8, 2025 13:51

__version__ = '0.5.1'

default_app_config = 'edx_event_bus_redis.apps.EdxEventBusRedisConfig' # pylint: disable=invalid-name
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

include README.rst
include requirements/base.in
include requirements/constraints.txt
recursive-include edx_event_bus_redis *.html *.png *.gif *.js *.css *.jpg *.jpeg *.svg
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package doesn't actually include any UI, so warnings were being thrown at build time about the lack of these files.

@@ -1,22 +0,0 @@

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was never used, it just came as part of the cookiecutter.

migrations

[wheel]
universal = 1
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Universal wheels were for Python 2.7 & 3 compatibility, they are no longer needed and warnings were being thrown at build time.

install_requires=load_requirements("requirements/base.in"),
python_requires=">=3.11",
license="AGPL 3.0",
license="AGPL-3.0-or-later",
Copy link
Copy Markdown
Contributor Author

@bmtcril bmtcril Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This more closely matches our removed classifier. https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license

'Framework :: Django',
'Framework :: Django :: 4.2',
'Intended Audience :: Developers',
'License :: OSI Approved :: GNU Affero General Public License v3 or later (AGPLv3+)',
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trove classifiers for license are deprecated and this threw a warning.

"context_processors": [
"django.contrib.auth.context_processors.auth", # this is required for admin
"django.contrib.messages.context_processors.messages", # this is required for admin
"django.template.context_processors.request", # this is required for admin
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is the only real change, it was throwing a warning at test time.

@bmtcril bmtcril merged commit 11ddb95 into main Apr 8, 2025
14 checks passed
@bmtcril bmtcril deleted the bmtcril/upgrade_django52 branch April 8, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Django 5.2 support to event-bus-redis

2 participants