Skip to content

feat!: remove deprecated signal parameter from consumer#26

Merged
bmtcril merged 1 commit intoopenedx:mainfrom
open-craft:navin/remove-signal-arg
May 23, 2023
Merged

feat!: remove deprecated signal parameter from consumer#26
bmtcril merged 1 commit intoopenedx:mainfrom
open-craft:navin/remove-signal-arg

Conversation

@navinkarkera
Copy link
Copy Markdown
Contributor

Description: Removes deprecated signal parameter and bumps openedx-events to 8.0.0

Dependencies:

Merge deadline: List merge deadline (if any)

Reviewers:

Merge checklist:

  • All reviewers approved
  • CI build is green
  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Commits are squashed

Post merge:

  • Create a tag
  • Check new version is pushed to PyPI after tag-triggered build is
    finished.
  • Delete working branch (if not needed anymore)

@openedx-webhooks
Copy link
Copy Markdown

Thanks for the pull request, @navinkarkera! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 23, 2023
@navinkarkera navinkarkera requested a review from bmtcril May 23, 2023 15:15
@navinkarkera navinkarkera self-assigned this May 23, 2023
@bmtcril bmtcril merged commit a3e7eb6 into openedx:main May 23, 2023
@openedx-webhooks
Copy link
Copy Markdown

@navinkarkera 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@navinkarkera navinkarkera deleted the navin/remove-signal-arg branch May 24, 2023 02:57
navinkarkera pushed a commit to open-craft/event-bus-redis that referenced this pull request May 24, 2023
feat!: remove deprecated signal parameter from consumer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants