Skip to content

build: tag this in future Open edX releases#53

Merged
kdmccormick merged 2 commits intomainfrom
kdmccormick/no-release-tag
Oct 10, 2023
Merged

build: tag this in future Open edX releases#53
kdmccormick merged 2 commits intomainfrom
kdmccormick/no-release-tag

Conversation

@kdmccormick
Copy link
Copy Markdown
Member

@kdmccormick kdmccormick commented Oct 10, 2023

build: don't tag this in the named release

@bmtcril , @cmltaWt0 mentioned that we shouldn't tag this in the release. Is that because it's installed via pip requirements?

UPDATE:

build: tag this in future Open edX releases

...because it's an optional plugin that will eventually be used by
the open source community.

@bmtcril
Copy link
Copy Markdown
Contributor

bmtcril commented Oct 10, 2023

It's because it depends on openedx-events, which is also not in the release

...because it's an optional plugin that will eventually be used by
the open source community.
@kdmccormick kdmccormick changed the title docs: don't tag this in the named release build: tag this in future Open edX releases Oct 10, 2023
@kdmccormick kdmccormick marked this pull request as ready for review October 10, 2023 18:53
@kdmccormick
Copy link
Copy Markdown
Member Author

@cmltaWt0 , could you review?

@cmltaWt0
Copy link
Copy Markdown

Make sense! Thanks.
Will be tagged and marked as experimental in the next release.
The same as openedx-unsupported/openedx-event-sink-clickhouse#52

@kdmccormick kdmccormick merged commit 2aeee56 into main Oct 10, 2023
@kdmccormick kdmccormick deleted the kdmccormick/no-release-tag branch October 10, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants