Forums V2 - More Invalid Parameters Being Passed For Thread Retrieval

[feoh]

During testing of forums we upgraded to V2, one of our users reported this issue where Discussions were producing an error on load for non admin users.

We were able to replicate this issue and tracked it to the following Sentry Issue which cites the likely cause of the issue as This PR/Commit - a response to an [issue we previously filed](openedx/openedx-platform#36450 along these lines.

This issue represents a blocker for our ongoing Forums V2 migration at MIT.

Thanks for your time and attention!

[taimoor-ahmed-1]

There is an error fetching user with id 232 as seen from the stack trace:

  File "openedx/core/djangoapps/django_comment_common/comment_client/user.py", line 208, in _retrieve
    response = forum_api.get_user(**params)
  File "forum/api/users.py", line 37, in get_user
    raise ForumV2RequestError(str(f"user not found with id: {user_id}"))

Can you confirm if this user exists in ForumUser model from django admin?

This error could potentially be causing the next error which we can see from the stack trace.

[feoh]

It seems we were setting the mysql backend flag globally which was causing this issue. Thanks to @taimoor-ahmed-1 for taking a look and to both Arslans for helping out :)

[asadali145]

Update:

I was looking into more details and had a call to discuss the order of flags with @taimoor-ahmed-1 for some clarity. We have identified steps to reproduce the issue with the V2 forums.

Here are the steps:

• Create a course with a discussion block
• Enable discussions.enable_forum_v2
• Keep the forum_v2.enable_mysql_backend disabled
• Visit the discussion block, and it won't load
• If discussions MFE is not enabled, then the discussions tab will also throw 500.
• If discussions MFE is enabled:
  • Go to the discussions tab, it will load fine
  • Go back to the discussion block; it will also load fine now.

I am reopening the issue.
CC: @feoh @pdpinch

[taimoor-ahmed-1]

I will be working on this today.

[taimoor-ahmed-1]

There is an open PR which should fix this issue: openedx/openedx-platform#36753
Can someone merge this?

[asadali145]

@taimoor-ahmed-1, there are failing tests on the PR I have requested the author to fix the tests.

[taimoor-ahmed-1]

I have opened a PR with the correct fix that aligns with the unit tests as well.

PR: openedx/openedx-platform#37245