Skip to content

feat: reskin of Profile MFE main page#1114

Merged
eemaanamir merged 12 commits into2u-mainfrom
INF-1570
Nov 18, 2024
Merged

feat: reskin of Profile MFE main page#1114
eemaanamir merged 12 commits into2u-mainfrom
INF-1570

Conversation

@eemaanamir
Copy link
Copy Markdown
Contributor

@eemaanamir eemaanamir commented Oct 24, 2024

Ticket: INF-1570

Backend PR: Link
edx-internal PR: Link

Reskinning the Profile MFE main page according to the provided Figma.

Before:

58ff4399398be30e272fca6cbd82712d

After:

localhost_1995_u_edx

@eemaanamir eemaanamir requested a review from a team as a code owner October 24, 2024 14:07
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 73.04075% with 86 lines in your changes missing coverage. Please review.

Project coverage is 68.72%. Comparing base (a134083) to head (3eaa383).
Report is 22 commits behind head on 2u-main.

Files with missing lines Patch % Lines
src/profile-v2/data/services.js 11.11% 45 Missing and 3 partials ⚠️
src/profile-v2/forms/ProfileAvatar.jsx 73.52% 9 Missing ⚠️
src/profile-v2/data/sagas.js 82.22% 7 Missing and 1 partial ⚠️
src/index.jsx 0.00% 7 Missing ⚠️
src/profile-v2/ProfilePage.jsx 90.47% 4 Missing ⚠️
src/data/reducers.js 0.00% 2 Missing ⚠️
src/data/sagas.js 0.00% 2 Missing ⚠️
src/profile-v2/NotFoundPage.jsx 0.00% 2 Missing ⚠️
src/profile-v2/data/constants.js 0.00% 2 Missing ⚠️
src/profile-v2/CertificateCard.jsx 87.50% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff             @@
##           2u-main    #1114      +/-   ##
===========================================
+ Coverage    67.12%   68.72%   +1.59%     
===========================================
  Files           51       71      +20     
  Lines          864     1180     +316     
  Branches       179      251      +72     
===========================================
+ Hits           580      811     +231     
- Misses         274      355      +81     
- Partials        10       14       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread src/data/reducers.js Outdated
Comment thread src/index.jsx Outdated
Comment thread src/data/reducers.js Outdated
Comment thread src/data/sagas.js Outdated
Comment thread src/data/sagas.js Outdated
Comment thread src/profile-v2/ProfilePage.jsx Outdated
Comment thread src/profile-v2/ProfilePage.jsx Outdated
Comment thread src/profile-v2/ProfilePage.jsx Outdated
Comment thread src/profile-v2/ProfilePage.jsx Outdated
Comment thread src/profile-v2/ProfilePage.jsx Outdated
Comment thread src/profile-v2/Certificates.jsx Outdated
Comment thread src/profile-v2/Certificates.messages.jsx
Comment thread src/profile-v2/ProfilePage.jsx Outdated
Comment thread src/profile-v2/ProfilePage.jsx Outdated
Copy link
Copy Markdown
Contributor

@sundasnoreen12 sundasnoreen12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR LGTM

@eemaanamir eemaanamir merged commit c025310 into 2u-main Nov 18, 2024
@eemaanamir eemaanamir deleted the INF-1570 branch November 18, 2024 08:36
awais-ansari added a commit that referenced this pull request Jul 10, 2025
* feat: added country disabling feature (#1084)

* feat: added country disabling feature

* fix: lint errors

* test: added test case for disabled countries

* refactor: combined test cases

* feat: reskin of Profile MFE main page (#1114)

* feat: reskin of Profile MFE main page

* feat: reskin of Profile MFE main page

* test: updated tests according to the changes

* fix: added missing name property

* test: updated test snapshot

* test: added tests for reducers

* feat: moved reskin logic behind env variable

* test: updated tests

* refactor: refactored code according to requested changes

* fix: fixed lint errors

* refactor: refactored code according to requested changes

* refactor: refactored code according to requested changes

* feat: fixed reloading issue

* fix: fixed responsiveness issues on mobile view (#1133)

* fix: fixed reponsiveness issues on mobile view

* test: updated tests

* refactor: refactored code as requested

* test: added not found test case

* test: updated test cases

* feat: added restricted country functionality

* fix: fixed test cases

* test: updated snapshot

* test: updated test cases

* feat: made profile editable (#1212)

* feat: readded editable fields to new profile view

* feat: made fullname editable and updated design

* test: updated test cases

* refactor: refactored code based on reviews

* feat: made fullname uneditable and added redirect link (#1215)

* feat: made fullname uneditable and added redirect link

* refactor: refactored code

* refactor: refactored code

* chore: rebase 2u-main with master (#1225)

* fix(deps): update dependency @edx/frontend-platform to v8.3.3 (#1187)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency core-js to v3.41.0 (#1188)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update `@openedx` dependencies to versions that support React 18 (#1189)

* chore(deps): update dependency @openedx/frontend-build to v14.4.1 (#1191)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update react-router monorepo to v6.30.0 (#1192)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* feat: upgrade react to v18 (#1190)

* fix(deps): update dependency @edx/frontend-platform to v8.3.4 (#1195)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @edx/frontend-component-footer to v14.4.0 (#1196)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @edx/frontend-component-header to v6.3.0 (#1197)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @edx/frontend-component-footer to v14.6.0 (#1199)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @edx/openedx-atlas to ^0.7.0 (#1200)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @edx/frontend-component-header to v6.4.0 (#1201)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* feat: import `FooterSlot` from component package instead of slot package (#1198)

* chore(deps): update dependency glob to v11.0.2 (#1202)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @edx/frontend-component-footer to v14.7.0 (#1203)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @edx/frontend-component-footer to v14.7.1 (#1204)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency core-js to v3.42.0 (#1205)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @edx/frontend-platform to v8.3.6 (#1207)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update commitlint monorepo to v19.8.1 (#1206)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @edx/frontend-platform to v8.3.7 (#1209)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @edx/frontend-component-footer to v14.7.2 (#1213)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update react-router monorepo to v6.30.1 (#1214)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @edx/frontend-platform to v8.3.9 (#1216)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @edx/frontend-component-footer to v14.9.0 (#1217)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* feat!: add design tokens support (#1220)

BREAKING CHANGE: Pre-design-tokens theming is no longer supported.

Co-authored-by: Diana Olarte <diana.olarte@edunext.co>

* fix: fixed lint issues

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Brian Smith <112954497+brian-smith-tcril@users.noreply.github.com>
Co-authored-by: Hunia Fatima <huniafatima99@gmail.com>
Co-authored-by: Diana Olarte <diana.olarte@edunext.co>
Co-authored-by: sundasnoreen12 <sundasnoreen12@gmail.com>

* fix: fixed font sizing issue after applying elm theme (#1228)

* Revert "fix: fixed font sizing issue after applying elm theme (#1228)" (#1232)

This reverts commit a9159f6.

---------

Co-authored-by: muhammadadeeltajamul <muhammadadeeltajamul@hotmail.com>
Co-authored-by: Muhammad Adeel Tajamul <77053848+muhammadadeeltajamul@users.noreply.github.com>
Co-authored-by: Eemaan Amir <57627710+eemaanamir@users.noreply.github.com>
Co-authored-by: sundasnoreen12 <sundasnoreen12@gmail.com>
Co-authored-by: sundasnoreen12 <72802712+sundasnoreen12@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Brian Smith <112954497+brian-smith-tcril@users.noreply.github.com>
Co-authored-by: Hunia Fatima <huniafatima99@gmail.com>
Co-authored-by: Diana Olarte <diana.olarte@edunext.co>
Co-authored-by: eemaanamir <eemaan.amir@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants