Skip to content

Layer ordering incorrect (shell coming in above paragon) #246

@brian-smith-tcril

Description

@brian-smith-tcril

Noticed double width bottom borders in instructor dash tabs

Image

found

layer paragon:
.nav-tabs {
    border-bottom: var(--pgn-size-nav-tabs-border-width) solid var(--pgn-color-nav-tabs-base-border-base);
}
layer shell
.course-tabs-navigation .nav-tabs
Specificity: (0,2,0)
 {
    border-bottom: none;
}

also found

Image

which doesn't match

/*
* Resource matchers for each cascade layer.
* Order declared at the site level: `paragon, shell, app, site, brand` (later wins).
*
* - paragon: @openedx/paragon base styles. First so everything else can override.
* - shell: frontend-base shell styles.
* - app: catch-all for any other stylesheet pulled from node_modules.
* Keeps apps from clobbering site or brand overrides without requiring
* app packages to follow any naming convention or self-declaration.
* - site: the composing site's own source tree (anything outside node_modules).
* - brand: @openedx/brand-* packages, last so build-time brand matches the
* precedence of runtime brand CSS (which is injected unlayered via
* <link> tags and thus beats every layered rule).
*/

or

@layer paragon, shell, app, site, brand;

We should figure out why the order is ending up incorrect and fix it.

Metadata

Metadata

Assignees

Type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions