fix: place desktop bell before the secondary-nav cluster#112
Merged
brian-smith-tcril merged 1 commit intoopenedx:frontend-basefrom Apr 29, 2026
Merged
Conversation
INSERT_BEFORE the desktopSecondaryLinks widget rather than the auth menu so the bell renders to the left of any secondary nav links (e.g. the help button from frontend-base#245) instead of between those links and the user avatar dropdown. Mobile is left as-is — mobileRight has no secondary-nav cluster to position relative to (just bell + auth menu), so INSERT_BEFORE the mobile auth menu remains correct. Refs openedx/frontend-base#245 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
brian-smith-tcril
force-pushed
the
help-button
branch
from
fa07511 to
3802e49
Compare
arbrandes
approved these changes
Apr 29, 2026
Contributor
arbrandes
left a comment
arbrandes
left a comment
There was a problem hiding this comment.
Approved for when the frontend-base PR lands.
jesusbalderramawgu
approved these changes
Apr 29, 2026
diana-villalvazo-wgu
approved these changes
Apr 29, 2026
|
🎉 This PR is included in version 3.0.0-alpha.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion PR to openedx/frontend-base#251. Repositions the desktop notifications bell to render before the secondary-nav cluster instead of between it and the user avatar dropdown.
relatedIdflips fromdesktopAuthenticatedMenutodesktopSecondaryLinks. With this change, the desktopRight cluster reads left-to-right as:[Bell, SecondaryNavLinks (incl. Help if configured), AuthenticatedMenu]Mobile is intentionally not changed —
mobileRight.v1only contains the bell and auth menu (no secondary-nav cluster on mobile), so INSERT_BEFORE-the-mobile-auth-menu remains correct.This PR targets the
frontend-basebranch to match where the rest of the help-button work lands.Test plan
commonAppConfig.SUPPORT_URLset, navigate to a route that activates one of the dashboard apps and authenticate[primary nav | bell | secondary links incl. Help | avatar]with the bell to the left of the help link[bell | avatar]unchanged🤖 Generated with Claude Code